Bug 31962 - [Qt] Fix some compiler warnings seen on QtWebKit/Mac
Summary: [Qt] Fix some compiler warnings seen on QtWebKit/Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 31924 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-11-29 14:34 PST by Laszlo Gombos
Modified: 2009-11-30 08:55 PST (History)
2 users (show)

See Also:

Attachments
proposed patch (3.11 KB, patch)
2009-11-29 14:56 PST, Laszlo Gombos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-29 14:34:24 PST 
Warnings to fix:

WebCore/plugins/mac/PluginPackageMac.cpp: In member function 'bool WebCore::PluginPackage::fetchInfo()':
WebCore/plugins/mac/PluginPackageMac.cpp:180: warning: label 'WTF' defined but not used

WebCore/plugins/mac/PluginViewMac.cpp: In member function 'void WebCore::PluginView::setNPWindowIfNeeded()':
WebCore/plugins/mac/PluginViewMac.cpp:384: warning: format '%d' expects type 'int', but argument 5 has type 'int32'
WebCore/plugins/mac/PluginViewMac.cpp:384: warning: format '%d' expects type 'int', but argument 6 has type 'int32'

WebCore/platform/network/ResourceHandle.h:99: warning: class WebCore::ResourceHandle has virtual functions but non-virtual destructor
Comment 1 Laszlo Gombos 2009-11-29 14:56:07 PST 
Created attachment 43992 [details]
proposed patch
Comment 2 WebKit Commit Bot 2009-11-30 08:42:34 PST 
Comment on attachment 43992 [details]
proposed patch

Clearing flags on attachment: 43992

Committed r51490: <http://trac.webkit.org/changeset/51490>
Comment 3 WebKit Commit Bot 2009-11-30 08:42:38 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Steve Block 2009-11-30 08:55:08 PST 
*** Bug 31924 has been marked as a duplicate of this bug. ***