Bug 31924 - ResourceHandle has virtual methods but non-virtual destructor
Summary: ResourceHandle has virtual methods but non-virtual destructor
Status: RESOLVED DUPLICATE of bug 31962
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-27 03:39 PST by Steve Block
Modified: 2009-11-30 08:55 PST (History)
3 users (show)

See Also:

Attachments
Patch 1 for Bug 31924 (1.12 KB, patch)
2009-11-27 03:45 PST, Steve Block 		eric: review+
steveblock: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-27 03:39:42 PST 
ResourceHandle has virtual methods but a non-virtual destructor. This can cause build warnings or errors.

These virtual methods were added in http://trac.webkit.org/changeset/50772.
Comment 1 Steve Block 2009-11-27 03:45:06 PST 
Created attachment 43940 [details]
Patch 1 for Bug 31924
Comment 2 Eric Seidel (no email) 2009-11-28 09:30:29 PST 
Comment on attachment 43940 [details]
Patch 1 for Bug 31924

OK.
Comment 3 Eric Seidel (no email) 2009-11-28 09:31:47 PST 
Please CC the folks who made the change when making a build fix. :)
http://trac.webkit.org/changeset/50772
Comment 4 Steve Block 2009-11-30 08:54:40 PST 
Already fixed in https://bugs.webkit.org/show_bug.cgi?id=31962, which was filed after this bug, but made it into the commit queue first.
Comment 5 Steve Block 2009-11-30 08:55:08 PST 

*** This bug has been marked as a duplicate of bug 31962 ***