Bug 31872 - centralize required argument parsing in Command
Summary: centralize required argument parsing in Command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 07:14 PST by Eric Seidel (no email)
Modified: 2009-11-25 08:05 PST (History)
1 user (show)

See Also:

Attachments
Centralize required argument parsing (9.65 KB, patch)
2009-11-25 07:23 PST, Eric Seidel (no email) 		abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-25 07:14:12 PST 
centralize required argument parsing in Command
Comment 1 Eric Seidel (no email) 2009-11-25 07:23:28 PST 
Created attachment 43842 [details]
Centralize required argument parsing
Comment 2 Adam Barth 2009-11-25 07:32:47 PST 
Comment on attachment 43842 [details]
Centralize required argument parsing

me: self.assertRaises(Exception, Command._parse_required_arguments, "[ARG1 ARG2]")
i guess that's ok

eric: I can make it smarter to handle that sort of thing
but for now I wanted to document that we didn't expect that to work

me: yeah, probably should add a comment that we might want to accept that case in the future
Comment 3 Eric Seidel (no email) 2009-11-25 07:34:50 PST 
Will land once bug 31870 is in.
Comment 4 Eric Seidel (no email) 2009-11-25 08:05:51 PST 
Committed r51383: <http://trac.webkit.org/changeset/51383>