Bug 31870 - Add OutputCaputure class for sharing capture_output between unit tests
Summary: Add OutputCaputure class for sharing capture_output between unit tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-25 07:11 PST by Eric Seidel (no email)
Modified: 2009-11-25 07:46 PST (History)
2 users (show)

See Also:


Attachments
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests. (7.04 KB, patch)
2009-11-25 07:23 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-25 07:11:57 PST
Add OutputCaputure class for sharing capture_output between unit tests
Comment 1 Eric Seidel (no email) 2009-11-25 07:23:21 PST
Created attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
Comment 2 Adam Barth 2009-11-25 07:28:22 PST
Comment on attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.

Looks good.  I had sketched this out as a base class, but compositing is better.
Comment 3 WebKit Commit Bot 2009-11-25 07:46:13 PST
Comment on attachment 43841 [details]
Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.

Clearing flags on attachment: 43841

Committed r51381: <http://trac.webkit.org/changeset/51381>
Comment 4 WebKit Commit Bot 2009-11-25 07:46:17 PST
All reviewed patches have been landed.  Closing bug.