RESOLVED FIXED 31816
Convert fast/table/row-height-recalc2.html to be 'dumpAsText()' 
https://bugs.webkit.org/show_bug.cgi?id=31816
Summary Convert fast/table/row-height-recalc2.html to be 'dumpAsText()'
Dmitry Titov
Reported 2009-11-23 18:19:13 PST
This test was recently added with 3 snapshots and Chromium would add another 2 so instead lets convert it to dumpAsText(). Test verifies that the computed height of the table row is reflecting the style setting done from JS. Verifying offsetHeight is fine. I've run this test on Safari 4.0.3 and ToT to verify it correctly catches the difference. If this is landed, then bug 31654 could be just closed.
Attachments
Proposed patch. (8.43 KB, patch)
2009-11-23 18:21 PST, Dmitry Titov 		dimich: commit-queue-
DetailsFormatted DiffDiff
Updated patch. (8.71 KB, patch)
2009-11-24 11:22 PST, Dmitry Titov 		eric: review+
dimich: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dmitry Titov
Comment 1 2009-11-23 18:21:20 PST
Created attachment 43745 [details] Proposed patch.
Eric Seidel (no email)
Comment 2 2009-11-23 19:38:41 PST
Comment on attachment 43745 [details] Proposed patch. Should we validate the hight before setting it to 100?
Dmitry Titov
Comment 3 2009-11-24 11:22:43 PST
Created attachment 43791 [details] Updated patch. Added validation of the row height before setting height to 100 from JS.
Eric Seidel (no email)
Comment 4 2009-11-24 11:24:04 PST
Comment on attachment 43791 [details] Updated patch. Yay! LGTM.
Dmitry Titov
Comment 5 2009-11-24 11:46:35 PST
Landed: http://trac.webkit.org/changeset/51344
Note You need to log in before you can comment on or make changes to this bug.