Bug 31654 - [Qt] Rebase Qt results for LayoutTest/fast/table/row-height-recalc2.html
Summary: [Qt] Rebase Qt results for LayoutTest/fast/table/row-height-recalc2.html
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-18 17:05 PST by Daniel Bates
Modified: 2009-11-24 00:43 PST (History)
11 users (show)

See Also:

Attachments
proposed patch (3.22 KB, patch)
2009-11-18 17:31 PST, Zoltan Horvath 		zoltan: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2009-11-18 17:05:48 PST 
The pixel-test/render-tree results for LayoutTest/sfast/table/row-height-recalc2.html are incorrect. The tests were originally generated (and passed) using Qt 4.5.2 on Ubuntu.

This test case was included in the patch for bug #24971.
Comment 1 Zoltan Horvath 2009-11-18 17:31:10 PST 
Created attachment 43473 [details]
proposed patch
Comment 2 Dmitry Titov 2009-11-18 17:33:49 PST 
I wonder if this test could be dumpAsText() variety so there would not be any platform-dependent results.
Comment 3 Eric Seidel (no email) 2009-11-19 01:06:50 PST 
Comment on attachment 43473 [details]
proposed patch

It seems we should just convert this to dump as text, no?  And use getComputedStyle() to get the height information we need.
Comment 4 Dmitry Titov 2009-11-23 18:29:33 PST 
I had to add 2 new rebaselines for Chromium so decided to just go ahead and convert this test to dumpAsText(). See bug 31816. I propose to do that conversion and resolve this bug as FIXED (or WONTFIX?) with a comment.
Comment 5 Zoltan Horvath 2009-11-24 00:40:49 PST 
Comment on attachment 43473 [details]
proposed patch

The test'll be converted to dumpAsTest in bug #31816.
Comment 6 Zoltan Horvath 2009-11-24 00:43:57 PST 
I set it to WONTFIX, because it'll be resolved in another way, in another bug (#31816).