Bug 31619 – Whitespaces after a list marker isn't ignored in calcInlinePrefWidths

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[Shinichiro Hamaji]

Created attachment 43416 [details]
test case with ahem

As mitz pointed in Bug 23264, whitespace characters after a list marker is added into the preferred width.

[Shinichiro Hamaji]

Created attachment 43417 [details]
Patch v1

I’m confused. If you fix this bug independently of bug 23264, you will have an inconsistency between calcPrefWidths() and findNextLineBreak(). I think you should change both at the same time.

[Shinichiro Hamaji]

It is already inconsistent for normal lists. Bug 23264 only fixes list-style-position:inside case and the rendering of normal lists was OK even before Bug 23264. Here is the summary of cases:

1. rendering of normal list: space is ignored (OK)
2. rendering of inside list: space is not ignored (not OK)
3. prefWidth of normal list: space is not ignored (not OK, inconsistent with case 1)
4. prefWidth of inside list: space is not ignored (not OK)

This patch fixes 3 and 4, and Bug 23264 fixes 2. Anyway, if you want to fix them at the same time, I'll combine the patches into one patch.

(In reply to comment #3)
> 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with
> case 1)

Do you have a test case showing this? This case seems to behave correctly to me.

> This patch fixes 3 and 4, and Bug 23264 fixes 2. Anyway, if you want to fix
> them at the same time, I'll combine the patches into one patch.

I suggest that you do that.

[Shinichiro Hamaji]

Comment on attachment 43417 [details]
Patch v1

Clearing review? as I'll combine this patch into Bug 23264

[Shinichiro Hamaji]

(In reply to comment #4)
> (In reply to comment #3)
> > 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with
> > case 1)
> 
> Do you have a test case showing this? This case seems to behave correctly to
> me.

I think the test case I attached in this bug shows this bug.

> I suggest that you do that.

Thanks for the quick response. I'll do it soon.

(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > 3. prefWidth of normal list: space is not ignored (not OK, inconsistent with
> > > case 1)
> > 
> > Do you have a test case showing this? This case seems to behave correctly to
> > me.
> 
> I think the test case I attached in this bug shows this bug.

You’re right! I was testing the wrong thing :)

[Shinichiro Hamaji]

> You’re right! I was testing the wrong thing :)

Yay, it's a very rare case. When the webkit reviewers disagree with me, almost always I'm wrong :)

[Shinichiro Hamaji]

*** This bug has been marked as a duplicate of bug 23264 ***