Bug 31564 - Rename CanvasObject to WebGLObject
Summary: Rename CanvasObject to WebGLObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-16 14:24 PST by Kenneth Russell
Modified: 2010-08-04 15:49 PDT (History)
6 users (show)

See Also:


Attachments
Patch (42.53 KB, patch)
2010-08-04 15:39 PDT, Kenneth Russell
dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-11-16 14:24:40 PST
The CanvasObject type isn't exposed in the public WebGL API, but it is used throughout the implementation. Per https://bugs.webkit.org/show_bug.cgi?id=29095 it should be renamed to WebGLObject and all of the subclasses updated.
Comment 1 Kenneth Russell 2010-08-04 15:39:39 PDT
Created attachment 63503 [details]
Patch

From the ChangeLog:

Renamed CanvasObject to WebGLObject using do-webcore-rename script. Because it seems the new convention is to not check in the changes made to this script, only checking in its effects. No new tests; built and ran WebGL in Safari and Chromium to test.
Comment 2 Dimitri Glazkov (Google) 2010-08-04 15:41:40 PDT
Comment on attachment 63503 [details]
Patch

rs=me.
Comment 3 WebKit Review Bot 2010-08-04 15:42:35 PDT
Attachment 63503 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/html/canvas/CanvasRenderingContext.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLProgram.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLBuffer.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLFramebuffer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLRenderbuffer.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLTexture.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebCore/html/canvas/WebGLObject.cpp:30:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
WebCore/html/canvas/WebGLShader.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 8 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Kenneth Russell 2010-08-04 15:45:28 PDT
Note: preexisting style violations in these files will be cleaned up in https://bugs.webkit.org/show_bug.cgi?id=38761 .
Comment 5 Kenneth Russell 2010-08-04 15:49:19 PDT
Committed r64685: <http://trac.webkit.org/changeset/64685>