Bug 38761 - Style cleanups in WebGL
Summary: Style cleanups in WebGL
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Kenneth Russell
Depends on:
Reported: 2010-05-07 10:54 PDT by Kenneth Russell
Modified: 2010-08-05 12:20 PDT (History)
7 users (show)

See Also:

Patch (163.78 KB, patch)
2010-08-04 17:19 PDT, Kenneth Russell
dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-05-07 10:54:38 PDT
There are a bunch of style violations reported by check-webkit-style that should be cleaned up.

Also, JSWebGLArrayHelper.h is not included in the XCode project.
Comment 1 Kenneth Russell 2010-08-04 17:19:52 PDT
Created attachment 63515 [details]

From the ChangeLog:

Cleaned up all style violations in WebGL-related files reported by check-webkit-style. No logic or other changes. Built WebKit and Chromium and ran WebGL layout tests.

Note to reviewers:

I apologize for the large size of this patch, but hopefully a quick visual inspection will show that the majority of the changes are white space adjustments to obey the indentation rules in namespaces. I can split it up if necessary, but this will prolong the pain of fixing these style violations.
Comment 2 Dimitri Glazkov (Google) 2010-08-04 20:02:46 PDT
Comment on attachment 63515 [details]

Holy moly that's a lot of style violations! I gave it a scan, and it looks ok. A tiny nit comment:

on *Impl suffix, I think the convention in WebKit is to use *Internal or private* prefix. So technically there's no convention, but I thought I'd mention it.
Comment 3 Kenneth Russell 2010-08-05 11:34:16 PDT
Committed r64767: <http://trac.webkit.org/changeset/64767>
Comment 4 WebKit Review Bot 2010-08-05 12:20:52 PDT
http://trac.webkit.org/changeset/64767 might have broken Leopard Intel Release (Tests)