The ARIA spec defines the directory role as "A list of references to members of a single group."
Created attachment 43238 [details]
Comment on attachment 43238 [details]
some reason there was an xcodeproj change
Created attachment 43239 [details]
Comment on attachment 43239 [details]
> + * accessibility/AccessibilityObject.h:
> + (WebCore::):
> + * accessibility/mac/AccessibilityObjectWrapper.mm:
> + (RoleEntry::):
These change log entries are wrong. If the script makes a bad entry like this you should just delete it before posting the patch.
I should fix prepare-ChangeLog so it never does that. A function name can never just end in "::" so I can work around the bug pretty easily.
> + DirectoryRole,
Can we keep these in alphabetical order?
> - return UI_STRING("tab panel", "An ARIA accessibility group that contenst the content of a tab.");
> + return UI_STRING("tab panel", "An ARIA accessibility group that contains the content of a tab.");
You need to regenerate the strings file after making a change like this one.
> > TabPanelRole,
> > TreeRole,
> > TreeItemRole,
> > + DirectoryRole,
> Can we keep these in alphabetical order?
Re-ordering those items will be a rather big change. i filed
to take care of that