Bug 31524 - AX: order AccessibilityRole alphabetically
Summary: AX: order AccessibilityRole alphabetically
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-15 17:50 PST by chris fleizach
Modified: 2011-04-25 21:37 PDT (History)
2 users (show)

See Also:

Attachments
patch (11.93 KB, patch)
2011-04-21 15:50 PDT, chris fleizach 		bdakin: review+
Details | Formatted Diff | Diff
patch to check building (no review necessary, want to check builders) (12.48 KB, patch)
2011-04-21 17:55 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch to check building (no review necessary) (13.56 KB, patch)
2011-04-21 18:57 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch to check building (no review) (12.48 KB, patch)
2011-04-21 19:15 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2009-11-15 17:50:51 PST 
we need to re-order AccessibilityRole list to be alphabetically (except UnknownRole which == 0)
Comment 1 chris fleizach 2009-12-13 13:43:47 PST 
the last ARIA role…
Comment 2 chris fleizach 2011-04-21 15:50:17 PDT 
Created attachment 90620 [details]
patch
Comment 3 WebKit Review Bot 2011-04-21 16:34:53 PDT 
Attachment 90620 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8498138
Comment 4 Beth Dakin 2011-04-21 17:36:24 PDT 
Comment on attachment 90620 [details]
patch

You should look into the linux-builder failure though.
Comment 5 chris fleizach 2011-04-21 17:55:59 PDT 
Created attachment 90644 [details]
patch to check building (no review necessary, want to check builders)
Comment 6 WebKit Review Bot 2011-04-21 17:59:21 PDT 
Attachment 90620 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8486592
Comment 7 chris fleizach 2011-04-21 17:59:44 PDT 
Comment on attachment 90644 [details]
patch to check building (no review necessary, want to check builders)

no reviewnecessary
Comment 8 WebKit Review Bot 2011-04-21 18:30:19 PDT 
Attachment 90644 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8495247
Comment 9 chris fleizach 2011-04-21 18:57:41 PDT 
Created attachment 90651 [details]
patch to check building (no review necessary)
Comment 10 WebKit Review Bot 2011-04-21 19:08:52 PDT 
Attachment 90651 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8493322
Comment 11 chris fleizach 2011-04-21 19:15:30 PDT 
Created attachment 90653 [details]
patch to check building (no review)
Comment 12 chris fleizach 2011-04-21 20:14:01 PDT 
http://trac.webkit.org/changeset/84593
Comment 13 Eric Seidel (no email) 2011-04-25 21:37:06 PDT 
Comment on attachment 90653 [details]
patch to check building (no review)

Cleared review? from attachment 90653 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).