I don't use SVG in my day-to-day debugging and it's a bunch of extra code for the compiler, linker, etc. to move around. I measured it at around 14.5% of the resulting binary size of a Debug build. We should allow building without SVG.
Created attachment 43195 [details] patch that is correct regardless of this bug
Created attachment 43196 [details] wip patch
Created attachment 43197 [details] wrap some code with ENABLE(SVG)
Comment on attachment 43197 [details] wrap some code with ENABLE(SVG) Clearing flags on attachment: 43197 Committed r51004: <http://trac.webkit.org/changeset/51004>
All reviewed patches have been landed. Closing bug.
still not done
(In reply to comment #6) > still not done Please use a new bug. We try to use one patch per bug. You can create a meta bug if you think people would like to track all the patches.
The patch you committed for me does not let us bulid without SVG; it was just the part of the patch I'd written that was inarguably correct.
What's the cost of making a new bug? I'm the only person on the CC list of this bug. If you create a new bug, then people trying to understand that patch will be saved from trying to understand the 9+ comments on this bug. If you'd like to see how the project manages a task that requires lots of patches, one example is <https://bugs.webkit.org/show_bug.cgi?id=29947>.
ok https://bugs.webkit.org/show_bug.cgi?id=31522