Bug 31490 - Allow building Chromium without SVG
Summary: Allow building Chromium without SVG
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-13 14:02 PST by Evan Martin
Modified: 2009-11-15 17:09 PST (History)
1 user (show)

See Also:


Attachments
patch that is correct regardless of this bug (933 bytes, patch)
2009-11-13 14:04 PST, Evan Martin
no flags Details | Formatted Diff | Diff
wip patch (3.72 KB, patch)
2009-11-13 14:05 PST, Evan Martin
no flags Details | Formatted Diff | Diff
wrap some code with ENABLE(SVG) (1.38 KB, patch)
2009-11-13 14:07 PST, Evan Martin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Martin 2009-11-13 14:02:51 PST
I don't use SVG in my day-to-day debugging and it's a bunch of extra code for the compiler, linker, etc. to move around.

I measured it at around 14.5% of the resulting binary size of a Debug build.

We should allow building without SVG.
Comment 1 Evan Martin 2009-11-13 14:04:59 PST
Created attachment 43195 [details]
patch that is correct regardless of this bug
Comment 2 Evan Martin 2009-11-13 14:05:31 PST
Created attachment 43196 [details]
wip patch
Comment 3 Evan Martin 2009-11-13 14:07:43 PST
Created attachment 43197 [details]
wrap some code with ENABLE(SVG)
Comment 4 Adam Barth 2009-11-15 15:29:40 PST
Comment on attachment 43197 [details]
wrap some code with ENABLE(SVG)

Clearing flags on attachment: 43197

Committed r51004: <http://trac.webkit.org/changeset/51004>
Comment 5 Adam Barth 2009-11-15 15:29:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Evan Martin 2009-11-15 16:10:09 PST
still not done
Comment 7 Adam Barth 2009-11-15 16:40:24 PST
(In reply to comment #6)
> still not done

Please use a new bug.  We try to use one patch per bug.  You can create a meta bug if you think people would like to track all the patches.
Comment 8 Evan Martin 2009-11-15 16:41:19 PST
The patch you committed for me does not let us bulid without SVG; it was just the part of the patch I'd written that was inarguably correct.
Comment 9 Adam Barth 2009-11-15 16:46:38 PST
What's the cost of making a new bug?  I'm the only person on the CC list of this bug.  If you create a new bug, then people trying to understand that patch will be saved from trying to understand the 9+ comments on this bug.

If you'd like to see how the project manages a task that requires lots of patches, one example is <https://bugs.webkit.org/show_bug.cgi?id=29947>.
Comment 10 Evan Martin 2009-11-15 17:09:50 PST
ok https://bugs.webkit.org/show_bug.cgi?id=31522