Bug 31445 - Rolling Chromium dependencies
Summary: Rolling Chromium dependencies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-12 16:01 PST by Yaar Schnitman
Modified: 2009-11-13 09:50 PST (History)
2 users (show)

See Also:


Attachments
Patch (815 bytes, patch)
2009-11-12 16:01 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff
deps role (1.30 KB, patch)
2009-11-13 09:36 PST, Yaar Schnitman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2009-11-12 16:01:23 PST
Created attachment 43110 [details]
Patch

The chromium port's dependencies are a bit behind.
Comment 1 WebKit Commit Bot 2009-11-12 17:50:37 PST
Comment on attachment 43110 [details]
Patch

Rejecting patch 43110 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11616 test cases.
fast/workers/worker-close.html -> crashed

Exiting early after 1 failures. 8388 tests run.
364.63s total testing time

8387 test cases (99%) succeeded
1 test case (<1%) crashed
3 test cases (<1%) had stderr output
Comment 2 Dimitri Glazkov (Google) 2009-11-12 18:19:03 PST
Comment on attachment 43110 [details]
Patch

let's try again.
Comment 3 WebKit Commit Bot 2009-11-12 18:36:02 PST
Comment on attachment 43110 [details]
Patch

Rejecting patch 43110 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
Comment 4 Dimitri Glazkov (Google) 2009-11-12 18:39:04 PST
Comment on attachment 43110 [details]
Patch

I am a bad boy. No ChangeLog.
Comment 5 Eric Seidel (no email) 2009-11-12 19:20:37 PST
Comment on attachment 43110 [details]
Patch

Filed bug 31453 about the crash.
Comment 6 Yaar Schnitman 2009-11-13 09:36:14 PST
Created attachment 43165 [details]
deps role
Comment 7 Dimitri Glazkov (Google) 2009-11-13 09:40:27 PST
Comment on attachment 43165 [details]
deps role

ok.
Comment 8 WebKit Commit Bot 2009-11-13 09:50:18 PST
Comment on attachment 43165 [details]
deps role

Clearing flags on attachment: 43165

Committed r50948: <http://trac.webkit.org/changeset/50948>
Comment 9 WebKit Commit Bot 2009-11-13 09:50:24 PST
All reviewed patches have been landed.  Closing bug.