Bug 31301 - [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
Summary: [V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 31200
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-10 09:24 PST by Vitaly Repeshko
Modified: 2009-11-10 18:15 PST (History)
3 users (show)

See Also:


Attachments
patch:layout test and fix (8.97 KB, patch)
2009-11-10 10:19 PST, Vitaly Repeshko
dglazkov: review+
Details | Formatted Diff | Diff
patch: layout test and fix v2 (8.98 KB, patch)
2009-11-10 10:30 PST, Vitaly Repeshko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2009-11-10 09:24:47 PST
[V8] Fix crash in V8CustomXPathNSResolver (http://crbug.com/26726).
Comment 1 Vitaly Repeshko 2009-11-10 10:19:47 PST
Created attachment 42874 [details]
patch:layout test and fix
Comment 2 Dimitri Glazkov (Google) 2009-11-10 10:26:05 PST
Comment on attachment 42874 [details]
patch:layout test and fix

>          // XPath-related utilities
> -        static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value)
> +        static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value, V8Proxy* proxy=0)

proxy = 0

otherwise, r=me.
Comment 3 Vitaly Repeshko 2009-11-10 10:30:19 PST
Created attachment 42875 [details]
patch: layout test and fix v2
Comment 4 Vitaly Repeshko 2009-11-10 10:30:36 PST
(In reply to comment #2)
> (From update of attachment 42874 [details])
> >          // XPath-related utilities
> > -        static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value)
> > +        static RefPtr<XPathNSResolver> getXPathNSResolver(v8::Handle<v8::Value> value, V8Proxy* proxy=0)
> 
> proxy = 0
> 
> otherwise, r=me.

Done. Thanks.
Comment 5 Dimitri Glazkov (Google) 2009-11-10 10:34:29 PST
Comment on attachment 42875 [details]
patch: layout test and fix v2

r=me. Hope the test expectations aren't generated on Chromium, like the last time ;)
Comment 6 WebKit Commit Bot 2009-11-10 10:41:28 PST
Comment on attachment 42875 [details]
patch: layout test and fix v2

Rejecting patch 42875 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11584 test cases.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html -> failed

Exiting early after 1 failures. 9001 tests run.
251.94s total testing time

9000 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output
Comment 7 Dimitri Glazkov (Google) 2009-11-10 10:50:17 PST
Comment on attachment 42875 [details]
patch: layout test and fix v2

spin again.
Comment 8 Eric Seidel (no email) 2009-11-10 10:57:08 PST
I've filed bug 31305 about the failure.  You should feel encouraged to file bugs about mysterious cq failures if you ever see them.
Comment 9 WebKit Commit Bot 2009-11-10 11:29:47 PST
Comment on attachment 42875 [details]
patch: layout test and fix v2

Rejecting patch 42875 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11584 test cases.
http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html -> failed

Exiting early after 1 failures. 9001 tests run.
246.13s total testing time

9000 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output
Comment 10 WebKit Commit Bot 2009-11-10 18:15:27 PST
Comment on attachment 42875 [details]
patch: layout test and fix v2

Clearing flags on attachment: 42875

Committed r50785: <http://trac.webkit.org/changeset/50785>
Comment 11 WebKit Commit Bot 2009-11-10 18:15:33 PST
All reviewed patches have been landed.  Closing bug.