Bug 31294 - [Qt] Font selection of generic fonts is broken
Summary: [Qt] Font selection of generic fonts is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P3 Normal
Assignee: Tor Arne Vestbø
Keywords: Qt
: 22896 29458 (view as bug list)
Depends on:
Reported: 2009-11-10 08:02 PST by Simon Hausmann
Modified: 2010-01-14 08:06 PST (History)
2 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2009-11-10 08:02:31 PST
The Qt port does not correctly choose the fonts specified in HTML/CSS.

This is a placeholder bug that we classify as showstopper for Qt 4.6.
Comment 1 Tor Arne Vestbø 2009-11-10 08:07:35 PST
In FontCache::getCachedFontPlatformData() we ignore the family argument which contains the resolved real font family from the web settings, and instead we pass on the generic font family to Qt. 

See also http://www.w3.org/TR/CSS2/fonts.html#generic-font-families

Quick fix here: http://gist.github.com/230871

Will try patch against 4.5 first to not mess up the buildbot too much.
Comment 2 Simon Hausmann 2009-11-23 05:31:36 PST
I believe this may be the same as bug #22896
Comment 3 Jocelyn Turcotte 2009-11-25 06:52:04 PST
*** Bug 22896 has been marked as a duplicate of this bug. ***
Comment 4 Tor Arne Vestbø 2009-12-21 04:24:17 PST
This was fixed in r51758
Comment 5 Jocelyn Turcotte 2010-01-14 08:06:00 PST
*** Bug 29458 has been marked as a duplicate of this bug. ***