Bug 31203 – [Qt] QWebPage::createPlugin() ignores visibility attribute in 4.5

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Nichols]

In Qt Extended 4.4.2, the visibility attribute in the <div> tag of an html file correctly hides a QLineEdit object on a QWebPage created by QWebPAge::createPlugin().
In Qt 4.5.3, the visibility attribute seems to be ignored altogether, resulting in the QLineEdit object always being visible.

<div id="hiddenLineEdit" style="visibility: hidden">
Hidden Field: <object type="application/x-qt-plugin" classid="LineEdit" height="30" width="180" contents="hide me" name="lineedit1"></object>
</div>

Attached example reproduces issue.

[Andy Nichols]

Created attachment 42645 [details]
Test Case

[Holger Freyther]

Created attachment 43127 [details]
Fix the cause of this bug

WebCore::Widget was handling show/hide properly but the QtPluginWidget::frameRectChanged was calling setVisible undoing the effect of show/hide.

[Kenneth Rohde Christiansen]

Comment on attachment 43127 [details]
Fix the cause of this bug

We have some manual-tests. Have you run those? Especially for testing the clipping. Also, doesn't WebCore::Widget have code for knowing if it is visible or not, that can be used instead of m_visible?

[Kenneth Rohde Christiansen]

Comment on attachment 43127 [details]
Fix the cause of this bug

Patch has been cherry-picked into Qt 4.6, but zecke will redo it for inclusion in trunk.

The test will be turned into a real layout test and the code will make use of setSelfVisible from WebCore::Widget.

[Holger Freyther]

Created attachment 43712 [details]
Move PluginViewQt.cpp PluginView::show/::hide to Widget::show/::hide

Fix the bug by making use of Widget::isVisible, isSelfVisible, isParentVisible... Update the manual test to include the problem seen here.

[Holger Freyther]

Created attachment 43713 [details]
Be able to automate tests including a QWidget

Print the QWidget properties as part of the RenderPart. This will require us to update some results but I have hundreds of test failures locally (by default...)

[Kenneth Rohde Christiansen]

Is this supposed to be up for review?

[Holger Freyther]

Comment on attachment 43712 [details]
Move PluginViewQt.cpp PluginView::show/::hide to Widget::show/::hide

Test cases are passing...

[Holger Freyther]

Created attachment 43756 [details]
Be able to automate plugin tests using a QWidget

Add new test, test result, update the other existing result

[Kenneth Rohde Christiansen]

Comment on attachment 43756 [details]
Be able to automate plugin tests using a QWidget

Great work.

Please remove 'Need a short description and bug URL (OOPS!)' from the ChangeLog

Should we be testing QGraphicsWidget based plugins as well? might widget in those cases be a QGrapicsWidget and not a QWidget?

[Holger Freyther]

Created attachment 43805 [details]
Be able to automate plugin test using a QWidget -- Fix the ChangeLog entry

Fix the ChangeLog entry, regarding the QGraphicsView and Qt plugins. I don't know yet.

[Holger Freyther]

Landed in r51410 and r51411. Leaving it open to wait for regressions to role in.

[Dimitri Glazkov (Google)]

Shouldn't the test have gone to platform/gt/plugins instead of just plugins?

[Holger Freyther]

(In reply to comment #13)
> Shouldn't the test have gone to platform/gt/plugins instead of just plugins?

For me it looked to be in the same class as the ObjC plugins that are in the plugin directory as well. We can consider moving all those away though.

[Jocelyn Turcotte]

*** Bug 29451 has been marked as a duplicate of this bug. ***

[Holger Freyther]

I waited for Dimitri to respond to my response. If Dimitri thinks there should
be more work done we can reopen the bug again, for now closing is the most easy
way to make it drop out of the review queue.

[Antonio Gomes]

*** Bug 35670 has been marked as a duplicate of this bug. ***