Bug 31184 - Geolocation error code UNKNOWN_ERROR is deprecated
Summary: Geolocation error code UNKNOWN_ERROR is deprecated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 28276
Blocks:
  Show dependency tree / graph
 
Reported: 2009-11-05 13:36 PST by Steve Block
Modified: 2009-11-06 13:36 PST (History)
4 users (show)

See Also:

Attachments
Patch 1 for Bug 31184 (17.14 KB, patch)
2009-11-05 14:12 PST, Steve Block 		eric: review+
Details | Formatted Diff | Diff
Patch 2 for Bug 31184 (19.43 KB, patch)
2009-11-06 11:12 PST, Steve Block 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-11-05 13:36:15 PST 
The error code UNKNOWN_ERROR has been dropped from the spec. See 'RESOLUTION: Drop UNKNOWN_ERROR' in the recent meeting minutes at http://www.w3.org/2009/11/02-geolocation-minutes.html.
Comment 1 Steve Block 2009-11-05 14:12:27 PST 
Created attachment 42595 [details]
Patch 1 for Bug 31184

This patch removes UNKNOWN_ERROR from the PositionError class. It also removes the constant from the JS PositionError object.
Comment 2 Eric Seidel (no email) 2009-11-05 15:22:10 PST 
Comment on attachment 42595 [details]
Patch 1 for Bug 31184

LGTM.
Comment 3 Steve Block 2009-11-05 16:33:03 PST 
Just realized that we shouldn't submit this until Bug 28276 is fixed. Eric, could you take a look at my patch for that one please?
Comment 4 Steve Block 2009-11-06 11:12:56 PST 
Created attachment 42661 [details]
Patch 2 for Bug 31184

Updated patch now that Bug 28276 is fixed.
Comment 5 Eric Seidel (no email) 2009-11-06 13:16:03 PST 
Comment on attachment 42661 [details]
Patch 2 for Bug 31184

Still LGTM.
Comment 6 WebKit Commit Bot 2009-11-06 13:36:40 PST 
Comment on attachment 42661 [details]
Patch 2 for Bug 31184

Clearing flags on attachment: 42661

Committed r50605: <http://trac.webkit.org/changeset/50605>
Comment 7 WebKit Commit Bot 2009-11-06 13:36:45 PST 
All reviewed patches have been landed.  Closing bug.