Bug 28276 - Geolocation error callback is invoked synchronously if service fails to start
Summary: Geolocation error callback is invoked synchronously if service fails to start
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Steve Block
URL:
Keywords:
Depends on: 27944 29179
Blocks: 31184
  Show dependency tree / graph
 
Reported: 2009-08-13 13:20 PDT by Steve Block
Modified: 2009-11-05 18:46 PST (History)
4 users (show)

See Also:

Attachments
Patch 1 for Bug 28276 (2.85 KB, patch)
2009-10-28 08:38 PDT, Steve Block 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2009-08-13 13:20:29 PDT 
Currently, when a Geolocation method is called, the error callback is invoked synchronously if the Geolocation service fails to start. 

This behavior is incorrect. All callbacks should be asynchronous. See the W3C spec - http://www.w3.org/TR/geolocation-API/#geolocation_interface.
Comment 1 Steve Block 2009-09-09 10:29:07 PDT 
The fix for this bug requires the 'setFatalError' framework in the fix for Bug 27944.
Comment 2 Steve Block 2009-10-28 08:38:00 PDT 
Created attachment 42029 [details]
Patch 1 for Bug 28276

Adding a test for this bug would require new methods to be added to the mock Geolocation service and LayoutTestController. For such a simple fix, I don't think it's worthwhile.
Comment 3 WebKit Commit Bot 2009-11-05 18:46:13 PST 
Comment on attachment 42029 [details]
Patch 1 for Bug 28276

Clearing flags on attachment: 42029

Committed r50585: <http://trac.webkit.org/changeset/50585>
Comment 4 WebKit Commit Bot 2009-11-05 18:46:17 PST 
All reviewed patches have been landed.  Closing bug.