Bug 31046 - committers.py needs a concept of "expired" committers/reviewers
Summary: committers.py needs a concept of "expired" committers/reviewers
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30970
  Show dependency treegraph
 
Reported: 2009-11-03 01:00 PST by Eric Seidel (no email)
Modified: 2010-06-10 19:32 PDT (History)
1 user (show)

See Also:


Attachments
Patch (7.98 KB, patch)
2009-11-05 16:37 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-11-03 01:00:16 PST
committers.py needs a concept of "expired" committers/reviewers

We have historical commits from folks in svn who are no longer part of the webkit project (mostly former Apple employees).  Committers.py should know about them as a central place to keep their real names, etc., but we don't currently have a way to store non-active committers in committers.py.  This bug is about adding such an ability.
Comment 1 Mark Rowe (bdash) 2009-11-03 13:38:18 PST
Given that we as the WebKit project don’t have a concept of “expired” committers or reviewers I think it would be premature to add one to this script without first discussing with the webkit-reviewers list exactly what this would entail.
Comment 2 Eric Seidel (no email) 2009-11-03 13:48:09 PST
Happy to discuss this further on any list.  This came out of research done as a part of bug 30970, where I discovered there are several folks who used to commit to webkit but no longer do. I assume (perhaps wrongly) that their commit bit might not even work anymore (since I know that some of those folks don't even work at Apple anymore).  It makes sense to me to document the existence of historical committers.  But I agree expired committers is a topic needing more public discussion.

See:
https://bug-30970-attachments.webkit.org/attachment.cgi?id=42352

Examples:
last commit     email                                   committers.py record
2005-03-09   goldsmit@apple.com       None
2005-03-07   kali@apple.com           None
2004-05-28   ouch@apple.com           None
2003-08-22   sheridan@apple.com       None
2003-08-12   voas@apple.com           None
2003-03-12   mhay@apple.com           None
Comment 3 Mark Rowe (bdash) 2009-11-03 14:23:17 PST
I don’t think that any of the people that you’ve listed even have commit access any more.
Comment 4 Eric Seidel (no email) 2009-11-03 14:25:25 PST
Yeah, I guess that's what I mean by "expired" committers.  Not a penalty box or anything.  Just record keeping of people who once committed to WebKit but no longer do.  That allows our scripts to deal with them as objects instead of just "goldsmit" (Which most people wouldn't know is actually goldsmit@apple.com or "Debbie Goldsmith".) :)
Comment 5 Eric Seidel (no email) 2009-11-05 16:37:36 PST
Created attachment 42609 [details]
Patch
Comment 6 Eric Seidel (no email) 2009-11-06 13:19:28 PST
Comment on attachment 42609 [details]
Patch

I think I've decided it's better to just add all committers who have ever committed to committers.py.  If we chose to "expire" some of them later, we can revisit this patch.