Bug 310037 – [WPE] Build broken on bot WPE-Linux-ARM32-bit-Release-Debian-Stable-Build after 309275@main.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Carlos Alberto Lopez Perez]

This is a similar issue than bug 310019

Building WPE ARM32 with clang fails with a -Wundefined-inline error because JSDOMConvertStrings.h calls JSValue::toWTFString() but never includes JSCJSValueInlines.h, where the body of that inline function is defined.

The error is:

WebCore/CMakeFiles/WebCore.dir/Modules/gamepad/GamepadHapticActuator.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/Modules/gamepad/GamepadHapticActuator.cpp.o -c /home/buildbot/worker/WPE-Linux-ARM32-bit-Release-Debian-Stable-Build/build/Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp
In file included from ../../../Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:37:
In file included from ../../../Source/WebCore/bindings/js/JSDOMConvertEnumeration.h:28:
In file included from WebCore/PrivateHeaders/WebCore/IDLTypes.h:28:
In file included from JavaScriptCore/PrivateHeaders/JavaScriptCore/HandleTypes.h:28:
JavaScriptCore/PrivateHeaders/JavaScriptCore/JSCJSValue.h:321:24: error: inline function 'JSC::JSValue::toWTFString' is not defined [-Werror,-Wundefined-inline]
  321 |     inline WTF::String toWTFString(JSGlobalObject*) const; // Defined in JSCJSValueInlines.h
      |                        ^
../../../Source/WebCore/bindings/js/JSDOMConvertStrings.h:73:29: note: used here
   73 |         auto string = value.toWTFString(&lexicalGlobalObject);
      |                             ^
1 error generated.
[25/1146] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-48.cpp.o

https://build.webkit.org/#/builders/860/builds/27386/steps/9/logs/stdio

This seems another include ordering bug related to missing header includes that trigger in this bot because of different ordering for the generated unified source files.

This started to happen after 309275@main

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/60709

[EWS]

Committed 309347@main (13eb470206f8): <https://commits.webkit.org/309347@main>

Reviewed commits have been landed. Closing PR #60709 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/172692871>