Bug 310019 – [WPE] Build broken on WPE-Linux-RPi4-32bits-Mesa-Release-Perf-Build after 309275@main

• Status: RESOLVED
• Resolution: FIXED
• Component: WPE WebKit

[Carlos Alberto Lopez Perez]

See: https://build.webkit.org/#/builders/893/builds/32744

In file included from ../../../Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:37:
../../../Source/WebCore/bindings/js/JSDOMConvertEnumeration.h: In instantiation of ‘static JSC::JSValue WebCore::JSConverter<WebCore::IDLEnumeration<T> >::convert(JSC::JSGlobalObject&, T) [with T = WebCore::GamepadHapticActuator::Result]’:
WebCore/PrivateHeaders/WebCore/JSDOMConvertBase.h:147:41:   required from ‘static JSC::JSValue WebCore::JSConverterOverloader<IDL, true, false>::convert(JSC::JSGlobalObject&, WebCore::JSDOMGlobalObject&, U&&) [with U = WebCore::GamepadHapticActuator::Result; IDL = WebCore::IDLEnumeration<WebCore::GamepadHapticActuator::Result>]’
WebCore/PrivateHeaders/WebCore/JSDOMConvertBase.h:176:47:   required from ‘JSC::JSValue WebCore::toJS(JSC::JSGlobalObject&, JSDOMGlobalObject&, U&&) [with IDL = IDLEnumeration<GamepadHapticActuator::Result>; U = GamepadHapticActuator::Result]’
../../../Source/WebCore/bindings/js/JSDOMPromiseDeferred.h:83:37:   required from ‘void WebCore::DeferredPromise::resolve(typename IDLType::ParameterType) [with IDLType = WebCore::IDLEnumeration<WebCore::GamepadHapticActuator::Result>; typename IDLType::ParameterType = WebCore::GamepadHapticActuator::Result]’
../../../Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:95:49:   required from here
../../../Source/WebCore/bindings/js/JSDOMConvertEnumeration.h:69:38: error: could not convert ‘WebCore::convertEnumerationToJS<GamepadHapticActuator::Result>((* &(& lexicalGlobalObject)->JSC::JSGlobalObject::vm()), value)’ from ‘JSC::JSString*’ to ‘JSC::JSValue’
   69 |         return convertEnumerationToJS(lexicalGlobalObject.vm(), value);
      |                ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                      |
      |                                      JSC::JSString*



But after fixing that one there are more build errors:

../../../Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:189:47: error: ‘makeScopeExit’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
  189 |                 auto scopeExit = makeScopeExit([protectedThis] {
      |                                  ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  190 |                     protectedThis->unblockControlMessageQueue();
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  191 |                 });
      |                 ~~                             


../../../Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:189:40:   required from here
../../../Source/WebCore/Modules/webcodecs/WebCodecsVideoDecoder.cpp:193:43: error: ‘makeScopeExit’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
  193 |             auto scopeExit = makeScopeExit([protectedThis] {
      |                              ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  194 |                 protectedThis->unblockControlMessageQueue();
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  195 |             });
      |             ~~                             
WTF/Headers/wtf/Scope.h:73:25: note: ‘template<class ExitFunction> WTF::ScopeExit<ExitFunction> WTF::makeScopeExit(ExitFunction&&)’ declared here, later in the translation unit
   73 | ScopeExit<ExitFunction> makeScopeExit(ExitFunction&& exitFunction)
      |                         ^~~~~~~~~~~~~



../../../Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:244:40:   required from here
../../../Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp:248:43: error: ‘makeScopeExit’ was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation
  248 |             auto scopeExit = makeScopeExit([protectedThis] {
      |                              ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
  249 |                 protectedThis->unblockControlMessageQueue();
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  250 |             });
      |             ~~                             
WTF/Headers/wtf/Scope.h:73:25: note: ‘template<class ExitFunction> WTF::ScopeExit<ExitFunction> WTF::makeScopeExit(ExitFunction&&)’ declared here, later in the translation unit
   73 | ScopeExit<ExitFunction> makeScopeExit(ExitFunction&& exitFunction)
      |

[Carlos Alberto Lopez Perez]

The problem seems missing includes that trigger on this bot because of different generated unified source files. This seems to have started to happen after 309275@main

[Carlos Alberto Lopez Perez]

Pull request: https://github.com/WebKit/WebKit/pull/60693

[EWS]

Committed 309326@main (e98736418011): <https://commits.webkit.org/309326@main>

Reviewed commits have been landed. Closing PR #60693 and removing active labels.