Revert my changes to Settings and instead implement DOM Storage enabling via the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
Created attachment 41525 [details] Patch v1
Comment on attachment 41525 [details] Patch v1 Wow. That's super cool.
Hmm. Adam reviewed at the same time.... Here were my comments: Two minor nits to fix on landing. > Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp > #include "ScriptSourceCode.h" > #include "SerializedScriptValue.h" > #include "Settings.h" > +#include "Storage.h" > #include "SharedWorkerRepository.h" "Storage" should be after "SharedWorker..." > Index: WebCore/storage/Storage.cpp > +#if USE(V8) > +// TODO: Remove once these features are turned on by default in Chromium. s/TODO/FIXME/
(In reply to comment #3) > Hmm. Adam reviewed at the same time.... > > Here were my comments: > > Two minor nits to fix on landing. > > > Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp > > #include "ScriptSourceCode.h" > > #include "SerializedScriptValue.h" > > #include "Settings.h" > > +#include "Storage.h" > > #include "SharedWorkerRepository.h" > > "Storage" should be after "SharedWorker..." Oops! > > Index: WebCore/storage/Storage.cpp > > +#if USE(V8) > > +// TODO: Remove once these features are turned on by default in Chromium. > > s/TODO/FIXME/ Yeah...I actually noticed this myself and was going to fix on landing.
Committed r50569: <http://trac.webkit.org/changeset/50569>
This was backed out because it broke QT. Now that they no-longer depend on it (https://bugs.webkit.org/show_bug.cgi?id=31249) it should go back in.
Comment on attachment 41525 [details] Patch v1 To be clear, the part that was backed out was just removing the session storage settings flag. I'll roll a new patch.
On second thought, it'd be better to split this bug out: https://bugs.webkit.org/show_bug.cgi?id=31279