RESOLVED FIXED 30602
[V8] DOM Storage runtime flag changes 
https://bugs.webkit.org/show_bug.cgi?id=30602
Summary [V8] DOM Storage runtime flag changes
Jeremy Orlow
Reported 2009-10-20 15:01:41 PDT
Revert my changes to Settings and instead implement DOM Storage enabling via the methods agreed upon in https://bugs.webkit.org/show_bug.cgi?id=30240
Attachments
Patch v1 (7.53 KB, patch)
2009-10-20 15:07 PDT, Jeremy Orlow 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2009-10-20 15:07:30 PDT
Created attachment 41525 [details] Patch v1
Adam Barth
Comment 2 2009-10-20 15:16:02 PDT
Comment on attachment 41525 [details] Patch v1 Wow. That's super cool.
David Levin
Comment 3 2009-10-20 15:18:19 PDT
Hmm. Adam reviewed at the same time.... Here were my comments: Two minor nits to fix on landing. > Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp > #include "ScriptSourceCode.h" > #include "SerializedScriptValue.h" > #include "Settings.h" > +#include "Storage.h" > #include "SharedWorkerRepository.h" "Storage" should be after "SharedWorker..." > Index: WebCore/storage/Storage.cpp > +#if USE(V8) > +// TODO: Remove once these features are turned on by default in Chromium. s/TODO/FIXME/
Jeremy Orlow
Comment 4 2009-10-20 15:25:57 PDT
(In reply to comment #3) > Hmm. Adam reviewed at the same time.... > > Here were my comments: > > Two minor nits to fix on landing. > > > Index: WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp > > #include "ScriptSourceCode.h" > > #include "SerializedScriptValue.h" > > #include "Settings.h" > > +#include "Storage.h" > > #include "SharedWorkerRepository.h" > > "Storage" should be after "SharedWorker..." Oops! > > Index: WebCore/storage/Storage.cpp > > +#if USE(V8) > > +// TODO: Remove once these features are turned on by default in Chromium. > > s/TODO/FIXME/ Yeah...I actually noticed this myself and was going to fix on landing.
Jeremy Orlow
Comment 5 2009-11-05 11:29:31 PST
Committed r50569: <http://trac.webkit.org/changeset/50569>
Jeremy Orlow
Comment 6 2009-11-09 11:12:29 PST
This was backed out because it broke QT. Now that they no-longer depend on it (https://bugs.webkit.org/show_bug.cgi?id=31249) it should go back in.
Jeremy Orlow
Comment 7 2009-11-09 11:13:30 PST
Comment on attachment 41525 [details] Patch v1 To be clear, the part that was backed out was just removing the session storage settings flag. I'll roll a new patch.
Jeremy Orlow
Comment 8 2009-11-09 16:49:19 PST
On second thought, it'd be better to split this bug out: https://bugs.webkit.org/show_bug.cgi?id=31279
Note You need to log in before you can comment on or make changes to this bug.