Bug 30592 - [Qt] keepWebHistory undefined while executing Layouttests fast/history/clicked-link-is-visited.html
Summary: [Qt] keepWebHistory undefined while executing Layouttests fast/history/clicke...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30574
  Show dependency treegraph
 
Reported: 2009-10-20 12:44 PDT by Chang Shu
Modified: 2009-10-21 12:19 PDT (History)
1 user (show)

See Also:


Attachments
fix patch (1.77 KB, patch)
2009-10-20 12:57 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2009-10-20 12:44:28 PDT
The following shows when executing LayoutTests: fast/history/clicked-link-is-visited.html

CONSOLE MESSAGE: line 6: TypeError: Result of expression
'layoutTestController.keepWebHistory' [undefined] is not a function.
Comment 1 Chang Shu 2009-10-20 12:57:52 PDT
Created attachment 41519 [details]
fix patch

Just added dummy implementation as it's implemented only on Mac.
Comment 2 Eric Seidel (no email) 2009-10-21 10:34:32 PDT
Comment on attachment 41519 [details]
fix patch

OK.  The ChangeLog should really mention which tests this affects.  If you want this auto-committed, you'll need to set cq?
Comment 3 Chang Shu 2009-10-21 10:39:07 PDT
(In reply to comment #2)
> (From update of attachment 41519 [details])
> OK.  The ChangeLog should really mention which tests this affects.  If you want
> this auto-committed, you'll need to set cq?

Thank you. Just did cq?
Comment 4 WebKit Commit Bot 2009-10-21 12:18:57 PDT
Comment on attachment 41519 [details]
fix patch

Clearing flags on attachment: 41519

Committed r49915: <http://trac.webkit.org/changeset/49915>
Comment 5 WebKit Commit Bot 2009-10-21 12:19:00 PDT
All reviewed patches have been landed.  Closing bug.