run LayoutTests/fast/history/clicked-link-is-visited.html with QtLauncher. expected result: "this link" should be shown in visited color actual result: "this link" does not show visited color
Created attachment 41510 [details] fix patch Two things probably can be discussed: 1. The expected text file is added to common folder. This may affect the test result for GTK, win platform (Mac has its own expected results). 2. The default color #551A8B is expected. Is this consistent on all platforms? Shall we set the visited color in the test case so as to make result consistent? Thanks!
Comment on attachment 41510 [details] fix patch Looks wrong. You're adding commented out code. +CONSOLE MESSAGE: line 6: TypeError: Result of expression 'layoutTestController.keepWebHistory' [undefined] is not a function. is wrong too.
(In reply to comment #2) > (From update of attachment 41510 [details]) > Looks wrong. You're adding commented out code. Sorry, I accidentally added the comment sign. Will remove it. > > +CONSOLE MESSAGE: line 6: TypeError: Result of expression > 'layoutTestController.keepWebHistory' [undefined] is not a function. > > is wrong too. This is existing code. Would it be possible that your workspace is out of date?
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 41510 [details] [details]) > > Looks wrong. You're adding commented out code. > > Sorry, I accidentally added the comment sign. Will remove it. > > > > > +CONSOLE MESSAGE: line 6: TypeError: Result of expression > > 'layoutTestController.keepWebHistory' [undefined] is not a function. > > > > is wrong too. > This is existing code. Would it be possible that your workspace is out of date? Wow, it is in my workspace. will double-check.
> > > +CONSOLE MESSAGE: line 6: TypeError: Result of expression > > > 'layoutTestController.keepWebHistory' [undefined] is not a function. > > > > > > is wrong too. > > This is existing code. Would it be possible that your workspace is out of date? > > Wow, it is in my workspace. will double-check. layoutTestController.keepWebHistory is missing on Qt. Just logged a bug 30592 and patched it with dummy implementation.
Created attachment 41610 [details] patch after dependency resolved
Comment on attachment 41610 [details] patch after dependency resolved The results don't go there I don't think. I expect the results for this test are per-platform. They probably should not be per-platform, but that would require changing the test. For now, you should probably just check in the results to platform/qt
Created attachment 41656 [details] put expected result in platform/qt
Comment on attachment 41656 [details] put expected result in platform/qt OK. Looks sane.
Comment on attachment 41656 [details] put expected result in platform/qt Rejecting patch 41656 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11475 test cases. inspector/console-tests.html -> failed Exiting early after 1 failures. 9209 tests run. 302.35s total testing time 9208 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output
Comment on attachment 41656 [details] put expected result in platform/qt I filed bug 30691.
Comment on attachment 41656 [details] put expected result in platform/qt Clearing flags on attachment: 41656 Committed r49957: <http://trac.webkit.org/changeset/49957>
All reviewed patches have been landed. Closing bug.