Bug 30575 – [GTK] eventSender.zoomPageOut() bug?

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Xan Lopez]

These tests:

fast/events/clientXY-in-zoom-and-scroll.html
fast/dom/elementFromPoint-relative-to-viewport.html

are both failing. The only thing in common they seem to have is that both are using eventSender.zoomPageOut(), which might not be working correctly.

[Martin Robinson]

*** Bug 35862 has been marked as a duplicate of this bug. ***

[Martin Robinson]

Created attachment 51231 [details]
Patch for this issue

It seems that DRT wasn't respecting the 1.2f zoom factor for full page zooms (only text zooms curiously). I've fixed this, removed some duplicate code and unskipped some failing tests. Some tests that used EventSender.zoomPage{Out/In}() are still failing. My intuition says these are probably valid bugs, but I think we should keep this bug open until we can get to the bottom of it.

[Xan Lopez]

Comment on attachment 51231 [details]
Patch for this issue

Looks good!

[Martin Robinson]

Committed r56316: <http://trac.webkit.org/changeset/56316>

[Eric Seidel (no email)]

Attachment 51231 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.

[Martin Robinson]

Committed as of r56316. I guess it makes sense to close this bug and open a new bug for the tests that are still failing.

[Zan Dobersek]

The tests covered by this bug were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt. Their expectations were removed in r116122[1] (covered by bug #85591). Nothing to close, moving on.

1: http://trac.webkit.org/changeset/116122