Bug 30575 - [GTK] eventSender.zoomPageOut() bug?
Summary: [GTK] eventSender.zoomPageOut() bug?
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Martin Robinson
: 35862 (view as bug list)
Depends on:
Reported: 2009-10-20 09:26 PDT by Xan Lopez
Modified: 2012-05-05 09:26 PDT (History)
4 users (show)

See Also:

Patch for this issue (6.60 KB, patch)
2010-03-20 13:56 PDT, Martin Robinson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2009-10-20 09:26:38 PDT
These tests:


are both failing. The only thing in common they seem to have is that both are using eventSender.zoomPageOut(), which might not be working correctly.
Comment 1 Martin Robinson 2010-03-20 13:54:02 PDT
*** Bug 35862 has been marked as a duplicate of this bug. ***
Comment 2 Martin Robinson 2010-03-20 13:56:41 PDT
Created attachment 51231 [details]
Patch for this issue

It seems that DRT wasn't respecting the 1.2f zoom factor for full page zooms (only text zooms curiously). I've fixed this, removed some duplicate code and unskipped some failing tests. Some tests that used EventSender.zoomPage{Out/In}() are still failing. My intuition says these are probably valid bugs, but I think we should keep this bug open until we can get to the bottom of it.
Comment 3 Xan Lopez 2010-03-20 14:12:35 PDT
Comment on attachment 51231 [details]
Patch for this issue

Looks good!
Comment 4 Martin Robinson 2010-03-21 12:09:57 PDT
Committed r56316: <http://trac.webkit.org/changeset/56316>
Comment 5 Eric Seidel (no email) 2010-03-24 14:32:29 PDT
Attachment 51231 [details] was posted by a committer and has review+, assigning to Martin Robinson for commit.
Comment 6 Martin Robinson 2010-03-24 14:35:59 PDT
Committed as of r56316. I guess it makes sense to close this bug and open a new bug for the tests that are still failing.
Comment 7 Zan Dobersek 2012-05-05 09:26:46 PDT
The tests covered by this bug were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt. Their expectations were removed in r116122[1] (covered by bug #85591). Nothing to close, moving on.

1: http://trac.webkit.org/changeset/116122