Bug 30311 – [Qt] Missing default value for the default text encoding

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Jakub Wieczorek]

So far the default charset has been hardcoded in the constructor of QWebPagePrivate:

// ### should be configurable
page->settings()->setDefaultTextEncodingName("iso-8859-1");

But since the addition of an equivalent setting in QWebSettings (https://bugs.webkit.org/show_bug.cgi?id=25863), this default value has had no effect because the above two lines are followed by:

settings = new QWebSettings(page->settings());

which applies the default global settings, where the default text encoding string is empty.

The default value should be moved to QWebSettings (as a result, it would also work when a page-specific encoding is reset to QString()).

This bug seems to trigger the fast/dom/Document/default-charset.html test failure.

[Jakub Wieczorek]

Created attachment 41056 [details]
proposed patch

Fixed the issue by moving the default setting to QWebSettings.
Added an auto test.
Unskipped fast/dom/Document/document-charset.html which is passing now.

[Simon Hausmann]

Comment on attachment 41056 [details]
proposed patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 41056 [details]
proposed patch

Clearing flags on attachment: 41056

Committed r49492: <http://trac.webkit.org/changeset/49492>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.