Please apply the following patch, exposing the default encoding property in QT
Created attachment 30470 [details] Patch exposing the property
Created attachment 30471 [details] Patch exposing the property
Comment on attachment 30471 [details] Patch exposing the property > Index: WebKit/qt/ChangeLog > =================================================================== > --- WebKit/qt/ChangeLog (revision 43858) > +++ WebKit/qt/ChangeLog (working copy) > @@ -1,3 +1,15 @@ > +2009-05-19 Jakob Truelsen <antialize@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Expose the default text encoding property to QT ^^^ no tabs! > /*! > + \since 4.6 > + Specifies the default text encoding system. > + > + The \a encoding, must be a string describing an encoding such as “utf-8”, “iso-8859-1", etc. > + > + \sa defaultTextEncoding() > +*/ > +void QWebSettings::setDefaultTextEncoding(const QString &encoding) > +{ > + d->defaultTextEncoding = encoding; > + d->apply(); > +} For the doc string, maybe you should refer to the Qt TextCodec's for other encodings and that an empty string will use whatever default?
Created attachment 30607 [details] A updated patch Updated the patch, with propper whitespace, and a better documentation
Comment on attachment 30607 [details] A updated patch looks good, for Qt4.6 the api might change.
Thanks. Landed in r44090. Some hints for future patches. Try to not have whitespace in the patch, no tabs in general (the commit will be rejected), put a reference to the bug into the commit log. :)
*** Bug 34751 has been marked as a duplicate of this bug. ***
*** Bug 32849 has been marked as a duplicate of this bug. ***