Bug 30299 - Fix profile grouping in the Profiles panel sidebar tree
Summary: Fix profile grouping in the Profiles panel sidebar tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 30253
  Show dependency treegraph
 
Reported: 2009-10-12 02:38 PDT by Alexander Pavlov (apavlov)
Modified: 2009-10-13 01:20 PDT (History)
2 users (show)

See Also:


Attachments
patch (1.91 KB, patch)
2009-10-12 02:47 PDT, Alexander Pavlov (apavlov)
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2009-10-12 02:38:26 PDT
Currently, grouping of the profiles with the same title is broken

Test case:
In the Console, enter the following series of commands:
console.profile('foo')
console.profileEnd()
console.profile('foo')
console.profileEnd()

The second profile node becomes a child of the first one's in the sidebar tree, while they should both become children named "Run N" of a new common parent node named "foo".
Comment 1 Alexander Pavlov (apavlov) 2009-10-12 02:47:35 PDT
Created attachment 41028 [details]
patch

Use the right parent when adding a new group node to the sidebar tree.
Comment 2 Pavel Feldman 2009-10-13 01:20:04 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/front-end/ProfilesPanel.js
Committed r49494