Bug 30253 - Alter profile link format to enable multiple profile types
Summary: Alter profile link format to enable multiple profile types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 30299
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-09 07:02 PDT by Alexander Pavlov (apavlov)
Modified: 2009-10-13 01:26 PDT (History)
2 users (show)

See Also:

Attachments
patch (3.98 KB, patch)
2009-10-09 08:44 PDT, Alexander Pavlov (apavlov) 		timothy: review+
Details | Formatted Diff | Diff
[IMAGE] Screenshot with regression (83.72 KB, image/png)
2009-10-12 01:54 PDT, Pavel Feldman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2009-10-09 07:02:21 PDT 
Currently, there is a single profile type (CPU profile) and its link URL format handled by WebInspector.documentClicked is as follows:

webkit-profile://<title>/<uid>

This does not warrant a possibility to introduce other types of profiles (say, Heap profiles).
The suggested profile link URL format that enables multiple profile types looks like this:

webkit-profile://<profileType>/<title>#<uid>
where <profileType>, <title>, and <uid> are URL-encoded.
Comment 1 Alexander Pavlov (apavlov) 2009-10-09 08:44:07 PDT 
Created attachment 40949 [details]
patch
Comment 2 Pavel Feldman 2009-10-12 01:53:05 PDT 
Not landing since this introduces a regression: CPU profiles with similar names are no longer grouped properly (see screenshot).
Comment 3 Pavel Feldman 2009-10-12 01:54:01 PDT 
Created attachment 41025 [details]
[IMAGE] Screenshot with regression
Comment 4 Alexander Pavlov (apavlov) 2009-10-12 02:40:02 PDT 
(In reply to comment #2)
> Not landing since this introduces a regression: CPU profiles with similar names
> are no longer grouped properly (see screenshot).

This is an unrelated regression. Filed as https://bugs.webkit.org/show_bug.cgi?id=30299
Comment 5 Pavel Feldman 2009-10-13 01:26:44 PDT 
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/inspector/InspectorController.cpp
	M	WebCore/inspector/front-end/inspector.js
Committed r49495