Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-10 08:16 PDT by Laszlo Gombos
Modified: 2009-10-15 09:55 PDT (History)
2 users (show)

See Also:

first try (4.84 KB, patch)
2009-10-10 12:24 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-10-10 08:16:18 PDT
I would propose the following changes:

 - Move the definition of ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH out from Gtk and Qt make system into port independent common code (Platform.h). This would also cut down on the length of the command line for compilation - which still seems to be a challenge in some embedded systems.

 - Enable ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH even if NETSCAPE_PLUGIN_API support is not enabled - this would allow removing some stubs from PluginPackageNone.cpp.

 - Remove notImplemented() from PluginPackageNone.cpp and PluginDataNone.cpp -  make them just empty functions (see also bug 30275 why this is desired)
Comment 1 Laszlo Gombos 2009-10-10 12:24:24 PDT
Created attachment 40993 [details]
first try
Comment 2 Eric Seidel (no email) 2009-10-10 19:44:15 PDT
Comment on attachment 40993 [details]
first try

tools like bugzilla-tool post-diff and git-send-bugzilla will automatically check the "patch" checkbox for you during upload.  Otherwise you'll need to do it yourself. :)
Comment 3 Simon Hausmann 2009-10-12 22:24:18 PDT
Comment on attachment 40993 [details]
first try

Nice cleanup :)
Comment 4 WebKit Commit Bot 2009-10-13 06:32:05 PDT
Comment on attachment 40993 [details]
first try

Rejecting patch 40993 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Last 500 characters of output:
Testing 11423 test cases.
http/tests/history/redirect-302.pl -> timed out
Sampling process 7317 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 7317 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 8478 tests run.
514.97s total testing time

8477 test cases (99%) succeeded
1 test case (<1%) timed out
4 test cases (<1%) had stderr output
Comment 5 Laszlo Gombos 2009-10-13 14:51:31 PDT
Comment on attachment 40993 [details]
first try

Will land manually.
Comment 6 Laszlo Gombos 2009-10-13 15:22:49 PDT
Landed as http://trac.webkit.org/changeset/49515.
Comment 7 Eric Seidel (no email) 2009-10-15 09:55:08 PDT
The problem here is a flakey test.  Sigh.  In these cases you're welcome to land it manually, or simply set cq+ again.  The commit-queue has no way to distinguish between flakey tests and real failures, so it always assumes failures are real. We need to get rid of all our flakey tests :(

Filed bug 30391.