WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30275
Build fix if Netscape plugin support is turned off
https://bugs.webkit.org/show_bug.cgi?id=30275
Summary
Build fix if Netscape plugin support is turned off
Laszlo Gombos
Reported
2009-10-10 05:30:14 PDT
r49158
,
r49159
and
r49169
caused a build break for configurations where Netscape plugin support is turned off.
Attachments
proposed patch
(5.25 KB, patch)
2009-10-10 05:39 PDT
,
Laszlo Gombos
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Laszlo Gombos
Comment 1
2009-10-10 05:39:20 PDT
Created
attachment 40989
[details]
proposed patch In addition to fixing the build break with guards remove notImplemented() from PluginViewNone.cpp and make them just just be empty functions. The later change was suggested by Darin in an earlier similar bug (see
https://bugs.webkit.org/show_bug.cgi?id=27940#c5
). - As some functions were already empty in PluginViewNone.cpp, this also makes the PluginViewNone.cpp more consistent.
Laszlo Gombos
Comment 2
2009-10-10 09:20:54 PDT
Comment on
attachment 40989
[details]
proposed patch Committed as
http://trac.webkit.org/changeset/49418
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug