Bug 30275 - Build fix if Netscape plugin support is turned off
Summary: Build fix if Netscape plugin support is turned off
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2009-10-10 05:30 PDT by Laszlo Gombos
Modified: 2009-10-10 09:21 PDT (History)
0 users

See Also:

proposed patch (5.25 KB, patch)
2009-10-10 05:39 PDT, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-10-10 05:30:14 PDT
r49158, r49159 and r49169 caused a build break for configurations where Netscape plugin support is turned off.
Comment 1 Laszlo Gombos 2009-10-10 05:39:20 PDT
Created attachment 40989 [details]
proposed patch

In addition to fixing the build break with guards remove notImplemented() from PluginViewNone.cpp and make them just just be empty functions. The later change was suggested by Darin in an earlier similar bug (see https://bugs.webkit.org/show_bug.cgi?id=27940#c5). - As some functions were already empty in PluginViewNone.cpp, this also makes the PluginViewNone.cpp more consistent.
Comment 2 Laszlo Gombos 2009-10-10 09:20:54 PDT
Comment on attachment 40989 [details]
proposed patch

Committed as http://trac.webkit.org/changeset/49418