Bug 30274 - HistoryController should point back to FrameLoader not Frame
: HistoryController should point back to FrameLoader not Frame
Status: RESOLVED WORKSFORME
: WebKit
Page Loading
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 29947
  Show dependency treegraph
 
Reported: 2009-10-10 02:27 PST by
Modified: 2009-10-14 21:26 PST (History)


Attachments
Patch v1 (29.56 KB, patch)
2009-10-10 02:28 PST, Adam Barth
no flags Review Patch | Details | Formatted Diff | Diff
HistoryController back pointer (29.59 KB, patch)
2009-10-10 02:42 PST, Adam Barth
darin: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-10 02:27:09 PST
Eric thinks HistoryController should point back to FrameLoader instead of Frame.  I'm not entirely convinced, but I made a patch to see what it would be like.  If he thinks we should do this, I'll defer to his experience.
------- Comment #1 From 2009-10-10 02:28:54 PST -------
Created an attachment (id=40987) [details]
Patch v1
------- Comment #2 From 2009-10-10 02:42:08 PST -------
Created an attachment (id=40988) [details]
HistoryController back pointer
------- Comment #3 From 2009-10-11 20:28:40 PST -------
(From update of attachment 40988 [details])
I think this is OK either way.

Pointing back to the frame is OK because everybody points back to the frame. It's all one big frame-lifetime-associated family of objects.

Pointing back to the frame loader is OK because the frame loader is the immediate owner of the history controller, and it's the thing the creates and destroys the history controller.

I have a hard time getting strong feelings either way.

The part I don't like is functions that are only needed once per page on the main frame that exist here on a pre-frame object.

r=me, and you can decide whether or not to land this. I really have no preference.
------- Comment #4 From 2009-10-14 21:26:51 PST -------
I think I'm going to leave this as-is.  Thanks for your comments.