Bug 30207 - Qt plugins : Don't sync in paint for opaque mode
Summary: Qt plugins : Don't sync in paint for opaque mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on: 20081
Blocks:
  Show dependency tree / graph
 
Reported: 2009-10-08 05:47 PDT by Girish Ramakrishnan
Modified: 2009-10-09 06:10 PDT (History)
2 users (show)

See Also:

Attachments
Move XSync after XCreatePixmap (2.81 KB, patch)
2009-10-08 05:50 PDT, Girish Ramakrishnan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Girish Ramakrishnan 2009-10-08 05:47:12 PDT 
Moves XSync to the right place.
Comment 1 Girish Ramakrishnan 2009-10-08 05:50:13 PDT 
Created attachment 40866 [details]
Move XSync  after XCreatePixmap
Comment 2 Simon Hausmann 2009-10-08 06:14:11 PDT 
Comment on attachment 40866 [details]
Move XSync  after XCreatePixmap

r=me
Comment 3 Simon Hausmann 2009-10-08 06:15:16 PDT 
One thing that would be good to double-check: We should only re-create the drawable if we are actually changing the _size_ of the plugin/widget. If we only change the position (i.e. we are scrolling) we should not re-create the pixmap and also avoid the expensive syncX() call.
Comment 4 WebKit Commit Bot 2009-10-08 06:26:01 PDT 
Comment on attachment 40866 [details]
Move XSync  after XCreatePixmap

Clearing flags on attachment: 40866

Committed r49296: <http://trac.webkit.org/changeset/49296>
Comment 5 WebKit Commit Bot 2009-10-08 06:26:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Girish Ramakrishnan 2009-10-08 06:48:10 PDT 
Simon, good catch! That check got lost in the QPixmap -> X Pixmap patch. I will create a patch for this one.