executeScript and executeIfJavaScriptURL are really about controlling scripts, not about loading pages. Therefore, we should move them from FrameLoader to ScriptController!
Created attachment 40856 [details] Patch v1
Created attachment 40857 [details] Patch v1
Comment on attachment 40857 [details] Patch v1 Can you first invent a x-platform ScriptController if your'e going to add duplicate code? ScriptController And then ScriptControllerJSC and ScriptControllerV8 which inherit from it? Or heck, you don't even need them to inherit. Just add a new ScriptController.cpp at the root level which has these fixes, and makes sure both builds include it, no? Unless this code is not copy/paste and I'm mising something? r- for adding copy/paste code.
Created attachment 40890 [details] Patch v1
Comment on attachment 40890 [details] Patch v1 ChangeLog is out of date. ScriptControllerBase being a real class would be better, but this is OK.
Comment on attachment 40890 [details] Patch v1 Rejecting patch 40890 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40890 from bug 30200 failed to download and apply.
Committed r49372: <http://trac.webkit.org/changeset/49372>
XCode project simply went out of date.