RESOLVED FIXED 30193
Move PolicyChecker to it's own file 
https://bugs.webkit.org/show_bug.cgi?id=30193
Summary Move PolicyChecker to it's own file
Adam Barth
Reported 2009-10-07 20:49:22 PDT
I'm also renaming PolicyCheck to PolicyCallback in the same change (to more clearly distinguish it from PolicyChecker).
Attachments
Patch v1 (36.84 KB, patch)
2009-10-07 20:50 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (36.87 KB, patch)
2009-10-07 20:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch v1 (36.87 KB, patch)
2009-10-07 21:39 PDT, Adam Barth 		eric: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-10-07 20:50:52 PDT
Created attachment 40838 [details] Patch v1
Adam Barth
Comment 2 2009-10-07 20:53:34 PDT
Created attachment 40840 [details] Patch v1
Adam Barth
Comment 3 2009-10-07 21:39:11 PDT
Created attachment 40842 [details] Patch v1
Eric Seidel (no email)
Comment 4 2009-10-07 22:06:01 PDT
Comment on attachment 40842 [details] Patch v1 Should it really be "PolicyCallback"? and not "NavigationPolicyCallback" or "LoadPolicyCallback" or "LoaderPolicyCalback"? Our indent-in-headers policy is under discussion on webkit-dev, but this change complies to the current style guidelines, so is fine as-is. cq- given the question about the naming, but otherwise looks fine. You could reply with some naming justification and set cq+ yourself if you like.
Adam Barth
Comment 5 2009-10-07 22:58:39 PDT
(In reply to comment #4) > Should it really be "PolicyCallback"? and not "NavigationPolicyCallback" or > "LoadPolicyCallback" or "LoaderPolicyCalback"? NavigationPolicyCallback isn't right because Navigation is just one of the three things it does. LoadPolicyCallback or LoaderPolicyCalback would be fine. We can change the name later if we like. I just wanted to make it different from PolicyChecker in the short term.
Adam Barth
Comment 6 2009-10-07 23:09:55 PDT
Comment on attachment 40842 [details] Patch v1 I need to land this manually.
Adam Barth
Comment 7 2009-10-07 23:17:32 PDT
Committed r49290: <http://trac.webkit.org/changeset/49290>
Note You need to log in before you can comment on or make changes to this bug.