WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
301359
Remove unused WebLocalFrameLoaderClient::m_useIconLoadingClient and related code
https://bugs.webkit.org/show_bug.cgi?id=301359
Summary
Remove unused WebLocalFrameLoaderClient::m_useIconLoadingClient and related code
Adrian Perez
Reported
2025-10-23 10:13:04 PDT
The WebLocalFrameLoaderClient::m_useIconLoadingClient member is set but never checked elsewhere, since
191542@main
. The current assumption is that an IconLoadingClient is always attached to a Page -- either the default, empty implementation, or a port-specific one (as done by GTK and Cocoa). Let's clean this up!
Attachments
Add attachment
proposed patch, testcase, etc.
Adrian Perez
Comment 1
2025-10-23 10:31:31 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/52895
EWS
Comment 2
2025-10-23 12:37:00 PDT
Committed
302050@main
(bab06beb1364): <
https://commits.webkit.org/302050@main
> Reviewed commits have been landed. Closing PR #52895 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2025-10-23 12:37:12 PDT
<
rdar://problem/163285876
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug