Bug 174700 – Get rid of WebCore IconDatabase code

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Get rid of WebCore IconDatabase code

[Brady Eidson]

Created attachment 316044 [details]
WIP patch (not for EWS yet)

Attaching WIP to get to it from another machine later

[Brady Eidson]

Created attachment 316069 [details]
Patch

[Build Bot]

Comment on attachment 316069 [details]
Patch

Attachment 316069 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4159609

New failing tests:
fast/dom/icon-url-list.html
fast/dom/icon-url-change.html
fast/dom/icon-url-without-mimetype.html

[Build Bot]

Created attachment 316074 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 316069 [details]
Patch

Attachment 316069 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4159626

New failing tests:
fast/dom/icon-url-list.html
fast/dom/icon-url-change.html
fast/dom/icon-url-without-mimetype.html

[Build Bot]

Created attachment 316075 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Tim Horton]

Comment on attachment 316069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316069&action=review

I mostly just looked at the green code. Obv. get EWS building.

> Source/WebCore/history/HistoryItem.cpp:-212
> -        iconDatabase().releaseIconForPageURL(m_urlString);

This was all pretty nutty, happy to see it go

> Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp:531
> +    // Add link icons they exist for this page, if we are archiving the entire page.

Grammar problem here.

> Source/WebCore/loader/icon/IconLoader.cpp:65
> +    ResourceRequest resourceRequest =  m_url;

Too many spaces after the =

[Build Bot]

Comment on attachment 316069 [details]
Patch

Attachment 316069 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4159635

New failing tests:
fast/dom/icon-url-list.html
fast/dom/icon-url-change.html
fast/dom/icon-url-without-mimetype.html

[Build Bot]

Created attachment 316076 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Brady Eidson]

Created attachment 316085 [details]
EWS run for building

I still have to reintroduce shortcutIconURLs for layout tests, and will do so - Just want all the other issues to run against this updated patch.

[Build Bot]

Comment on attachment 316085 [details]
EWS run for building

Attachment 316085 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4162049

New failing tests:
fast/dom/icon-url-list.html
fast/dom/icon-url-change.html
fast/dom/icon-url-without-mimetype.html

[Build Bot]

Created attachment 316093 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 316085 [details]
EWS run for building

Attachment 316085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4162052

New failing tests:
fast/dom/icon-url-list.html
fast/dom/icon-url-change.html
fast/dom/icon-url-without-mimetype.html

[Build Bot]

Created attachment 316095 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Brady Eidson]

Created attachment 316096 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 316096 [details]
Patch

Clearing flags on attachment: 316096

Committed r219733: <http://trac.webkit.org/changeset/219733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.