WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
30111
Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111
Summary
Move FrameLoader::canLoad to SecurityOrigin
Adam Barth
Reported
2009-10-05 23:57:43 PDT
Move FrameLoader::canLoad to SecurityOrigin
Attachments
Patch v1
(22.68 KB, patch)
2009-10-05 23:59 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2009-10-05 23:59:03 PDT
Created
attachment 40697
[details]
Patch v1
Eric Seidel (no email)
Comment 2
2009-10-06 09:55:48 PDT
Comment on
attachment 40697
[details]
Patch v1 This is a little trickier than I expected since you're changing the signature of the function as you move it, but looks OK. Also, I wonder if we shouldn't rename this "mayLoad" to satisfy my 3rd grade english teacher. :)
Adam Barth
Comment 3
2009-10-06 10:29:06 PDT
There's a bunch of other canFoo methods on security origin already. I support renaming them, but we should do them all at the same time.
WebKit Commit Bot
Comment 4
2009-10-06 18:14:31 PDT
Comment on
attachment 40697
[details]
Patch v1 Clearing flags on attachment: 40697 Committed
r49212
: <
http://trac.webkit.org/changeset/49212
>
WebKit Commit Bot
Comment 5
2009-10-06 18:14:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug