Bug 30109 - Move m_openedByDOM to Page
Summary: Move m_openedByDOM to Page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 29947
  Show dependency treegraph
 
Reported: 2009-10-05 22:14 PDT by Adam Barth
Modified: 2009-10-06 11:20 PDT (History)
2 users (show)

See Also:


Attachments
Patch v1 (5.35 KB, patch)
2009-10-05 22:15 PDT, Adam Barth
abarth: commit-queue-
Details | Formatted Diff | Diff
patch with typos fixed. (6.45 KB, patch)
2009-10-05 23:05 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2009-10-05 22:14:39 PDT
We only need one instance of m_openedByDOM per page, we should move it to a page-scoped object.  Notice that it's only ever touched for the main frame.
Comment 1 Adam Barth 2009-10-05 22:15:48 PDT
Created attachment 40688 [details]
Patch v1
Comment 2 Adam Barth 2009-10-05 22:53:13 PDT
Comment on attachment 40688 [details]
Patch v1

There are two typos I need to fix before landing.
Comment 3 Adam Barth 2009-10-05 23:05:32 PDT
Created attachment 40693 [details]
patch with typos fixed.
Comment 4 Eric Seidel (no email) 2009-10-06 09:50:39 PDT
Comment on attachment 40693 [details]
patch with typos fixed.

LGTM.
Comment 5 WebKit Commit Bot 2009-10-06 11:20:41 PDT
Comment on attachment 40693 [details]
patch with typos fixed.

Clearing flags on attachment: 40693

Committed r49196: <http://trac.webkit.org/changeset/49196>
Comment 6 WebKit Commit Bot 2009-10-06 11:20:45 PDT
All reviewed patches have been landed.  Closing bug.