Bug 30094 - Incorrect forward declaration of 'struct FrameLoadRequest' as 'class FrameLoadRequest' leads to compile warnings
: Incorrect forward declaration of 'struct FrameLoadRequest' as 'class FrameLoa...
Status: RESOLVED FIXED
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2009-10-05 13:51 PST by
Modified: 2009-10-05 21:17 PST (History)


Attachments
Patch to fix decl (766 bytes, patch)
2009-10-05 13:53 PST, James Robinson
barraclough: review+
commit-queue: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Patch including ChangeLog entry (912 bytes, patch)
2009-10-05 14:28 PST, James Robinson
eric: review+
commit-queue: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Moves the decl down with the other 'struct ...' declaration (966 bytes, patch)
2009-10-05 14:39 PST, James Robinson
darin: review+
commit-queue: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Removes "No new tests (OOPS) line from ChangeLog" (933 bytes, patch)
2009-10-05 16:00 PST, James Robinson
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-10-05 13:51:00 PST
Summary says it all.
------- Comment #1 From 2009-10-05 13:53:05 PST -------
Created an attachment (id=40658) [details]
Patch to fix decl
------- Comment #2 From 2009-10-05 14:17:35 PST -------
(From update of attachment 40658 [details])
Rejecting patch 40658 from commit-queue.

Found no modified ChangeLogs, cannot create a commit message.
All changes require a ChangeLog.  See:
http://webkit.org/coding/contributing.html
------- Comment #3 From 2009-10-05 14:28:41 PST -------
Created an attachment (id=40661) [details]
Patch including ChangeLog entry
------- Comment #4 From 2009-10-05 14:31:01 PST -------
(From update of attachment 40661 [details])
LGTM.  I'm assuming you meant cq? as well.  (Sadly bugzilla-tool post-diff has no --commit-queue option yet.  bug 29202.)
------- Comment #5 From 2009-10-05 14:32:07 PST -------
The struct one should go down in the next paragraph with the other struct rather than in the class paragraph.
------- Comment #6 From 2009-10-05 14:36:17 PST -------
(From update of attachment 40661 [details])
Rejecting patch 40661 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1
Running build-dumprendertree
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 11378 test cases.
fast/dom/prototype-inheritance.html -> failed

Exiting early after 1 failures. 5487 tests run.
95.67s total testing time

5486 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
1 test case (<1%) had stderr output
------- Comment #7 From 2009-10-05 14:39:26 PST -------
Created an attachment (id=40663) [details]
Moves the decl down with the other 'struct ...' declaration
------- Comment #8 From 2009-10-05 14:57:27 PST -------
Sorry, the bots were behind.  They were showing green but the build was actually red.  Hence the invalid rejection.  I'll file a bug about the commit-queue not noticing that hte bots were behind.
------- Comment #9 From 2009-10-05 15:02:22 PST -------
False rejection was caused by bug 30098.
------- Comment #10 From 2009-10-05 15:54:39 PST -------
(From update of attachment 40663 [details])
Rejecting patch 40663 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
    M    WebCore/ChangeLog
    M    WebCore/loader/RedirectScheduler.h
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebCore/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469
------- Comment #11 From 2009-10-05 15:57:24 PST -------
Need to remove the "No new tests (OOPS)" line from the change log.
------- Comment #12 From 2009-10-05 16:00:28 PST -------
Created an attachment (id=40670) [details]
Removes "No new tests (OOPS) line from ChangeLog"
------- Comment #13 From 2009-10-05 17:27:20 PST -------
(From update of attachment 40670 [details])
Rejecting patch 40670 from commit-queue.

Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1
Last 500 characters of output:
rivedSources/WebCore/JSCanvasRenderingContext3D.cpp -o /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/JSCanvasRenderingContext3D.o
** BUILD FAILED **

The following build commands failed:
WebCore:
    Distributed-CompileC /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/RenderThemeMac.o /Users/eseidel/Projects/CommitQueue/WebCore/rendering/RenderThemeMac.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2
(1 failure)
------- Comment #14 From 2009-10-05 21:01:15 PST -------
(From update of attachment 40670 [details])
The commit-queue has landed nearly 400 patches by now, and this is the first time I've seen false failures like these.  So either this is a real failure caused by this patch, or you've hit bug 30098 twice (I saw bug 30098 for the first time today!).  Not sure yet.  Either way, my apologies for the inconvenience.
------- Comment #15 From 2009-10-05 21:12:49 PST -------
(From update of attachment 40670 [details])
Clearing flags on attachment: 40670

Committed r49144: <http://trac.webkit.org/changeset/49144>
------- Comment #16 From 2009-10-05 21:12:53 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #17 From 2009-10-05 21:17:02 PST -------
Thanks!  I was just abou to fix this.  ;)