Bug 29202 – bugzilla-tool post-diff should know how to mark commit-queue=?

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

bugzilla-tool post-diff should know how to mark commit-queue=?

Would be easy to write.  The question is what the default should be.  I assume it should default to not marking.  Although maybe it should do a lookup of your bugzilla username in committers.py and default to true for non-committers?  Would that be too subtle?

[Adam Barth]

I'm not sure this is worth doing by default.

[Eric Seidel (no email)]

Created attachment 41588 [details]
Add --commit-queue support

[Adam Barth]

Comment on attachment 41588 [details]
Add --commit-queue support

I don't think we should call it --commit-queue.  That name is already taken in land-patches as a command line argument.

[Eric Seidel (no email)]

Well, it's very easy to change the name on land-patches, since that's only ever used by one person... me.  I think --commit-queue or --request-commit seem most appropriate to me.  do you have suggestions?

[Eric Seidel (no email)]

--request-auto-commit could work too, but seems kinda long.

[Adam Barth]

(In reply to comment #4)
>  --request-commit

I like this one.

[Eric Seidel (no email)]

Created attachment 41613 [details]
Add --request-commit support

[Adam Barth]

Comment on attachment 41613 [details]
Add --request-commit support

ok

[WebKit Commit Bot]

Comment on attachment 41613 [details]
Add --request-commit support

Rejecting patch 41613 from commit-queue.

Failed to run "['git', 'svn', 'dcommit']" exit_code: 1
Last 500 characters of output:
tory/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/bugzilla.py
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebKitTools/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/libexec/git-core//git-svn line 469

[Eric Seidel (no email)]

I need to make svn-apply smarter to handle these ChagneLogs. :(

[Eric Seidel (no email)]

svn-apply is now smarter, but waiting review.  Faster to just land this by hand.

[Eric Seidel (no email)]

Committed r50107: <http://trac.webkit.org/changeset/50107>