Bug 30020 - [chromium] Fix WebGL build after CustomGetter constructor changes
Summary: [chromium] Fix WebGL build after CustomGetter constructor changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-02 09:32 PDT by Kenneth Russell
Modified: 2009-12-15 14:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.21 KB, patch)
2009-10-02 09:37 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-10-02 09:32:55 PDT 
https://bugs.webkit.org/show_bug.cgi?id=29940 changed the form of V8 bindings for constructors marked CustomGetter. The constructors being proposed in the WebGL spec for new array-like objects don't need this special treatment so the CustomGetter should be changed to JSCCustomGetter. I'm not 100% sure even this attribute is needed but I've built both WebKit and Chromium with this change and verified that it fixes the Chromium WebGL build without affecting the WebKit build.
Comment 1 Kenneth Russell 2009-10-02 09:37:31 PDT 
Created attachment 40530 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2009-10-02 11:55:16 PDT 
Can we just make these non-custom? Doesn't look like they're doing much.
Comment 3 Kenneth Russell 2009-10-02 14:16:51 PDT 
I tried removing the JSCCustomGetter attribute and doing so breaks the WebKit build. It seems this patch is correct for both Chrome and WebKit.
Comment 4 Dimitri Glazkov (Google) 2009-10-02 15:06:57 PDT 
Comment on attachment 40530 [details]
Patch

ok.
Comment 5 WebKit Commit Bot 2009-10-02 15:33:48 PDT 
Comment on attachment 40530 [details]
Patch

Clearing flags on attachment: 40530

Committed r49049: <http://trac.webkit.org/changeset/49049>
Comment 6 WebKit Commit Bot 2009-10-02 15:33:51 PDT 
All reviewed patches have been landed.  Closing bug.