Bug 29940 - [V8] HTMLAudio, HTMLImageElement, and HTMLOptionElement are constructable.
Summary: [V8] HTMLAudio, HTMLImageElement, and HTMLOptionElement are constructable.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-30 16:07 PDT by Dimitri Glazkov (Google)
Modified: 2009-09-30 20:00 PDT (History)
0 users

See Also:

Attachments
Patch v1 (18.15 KB, patch)
2009-09-30 16:07 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Make things less constructable, v2. (18.21 KB, patch)
2009-09-30 16:15 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Make things less constructable, v3. (18.27 KB, patch)
2009-09-30 16:23 PDT, Dimitri Glazkov (Google) 		fishd: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-09-30 16:07:36 PDT 
Created attachment 40406 [details]
Patch v1

Due to my refactoring earlier this year, I accidentally made HTML(Audio|Image|Op
tion)Element properties constructable. This patch mimics JSC's behavior and crea
tes a distinction between them and just plain window.Audio, Image, and Option.[A[B
Comment 1 Dimitri Glazkov (Google) 2009-09-30 16:09:36 PDT 
Comment on attachment 40406 [details]
Patch v1

Missing bug URL :)
Comment 2 Dimitri Glazkov (Google) 2009-09-30 16:15:12 PDT 
Created attachment 40407 [details]
Make things less constructable, v2.
Comment 3 Dimitri Glazkov (Google) 2009-09-30 16:22:31 PDT 
Comment on attachment 40407 [details]
Make things less constructable, v2.

Real thing coming up.
Comment 4 Dimitri Glazkov (Google) 2009-09-30 16:23:12 PDT 
Created attachment 40408 [details]
Make things less constructable, v3.
Comment 5 Dimitri Glazkov (Google) 2009-09-30 20:00:10 PDT 
Landed as http://trac.webkit.org/changeset/48955.