Bug 29856 – [Qt] gotoAnchor in QtWebKit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Tor Arne Vestbø]

This bug report originated from issue QTBUG-3390
http://bugreports.qt.nokia.com/browse/QTBUG-3390

--- Description ---

The gotoAnchor function is available in webkit, but it does not have a Qt wrapper function so that it is available to use. It is the function that scrolls the web page to an html anchor on that page. I am using setHtml to load locally generated html and I want to be able to scroll to a specified point in that html. 

This should be very easy to fix since only a Qt wrapper function is needed to access an existing function in webkit.

[Antonio Gomes]

*** Bug 29885 has been marked as a duplicate of this bug. ***

[Ariya Hidayat]

Created attachment 48791 [details]
Patch

[Simon Hausmann]

Comment on attachment 48791 [details]
Patch

Nice!

> +void QWebFrame::scrollToAnchor(const QString &anchor)
[...]
> +    void scrollToAnchor(const QString &anchor);

Would be good to fix the & position before landing :)

[Ariya Hidayat]

> > +void QWebFrame::scrollToAnchor(const QString &anchor)
> [...]
> > +    void scrollToAnchor(const QString &anchor);
> 
> Would be good to fix the & position before landing :)

The whole file is still using Qt code style for this. Should I switch to WebKit's for this particular function only?

[Ariya Hidayat]

Manually committed in r54857: http://trac.webkit.org/changeset/54857