WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
298004
Add a Test-Sequence header to the webkitpy <-> WKTR/DRT server protocol
https://bugs.webkit.org/show_bug.cgi?id=298004
Summary
Add a Test-Sequence header to the webkitpy <-> WKTR/DRT server protocol
Sam Sneddon [:gsnedders]
Reported
2025-08-27 18:43:42 PDT
We've had a variety of off-by-one errors across the protocol over the years. e.g.,
bug 235733
,
bug 273212
,
bug 274330
. We should make these a lot harder to accidentally slip through, not least because they can cause bogus results for the rest of the test run. Adding a Test-Sequence header, where WKTR and DRT and webkitpy can all keep count of the number of run test commands sent, allows some basic synchronisation. It's less ideal than setting some abstract UUID (because incrementing accidentally is a lot easier), but it's possible to land this in a low-risk, low-impact way that doesn't break the communication protocol and you can still use current webkitpy with older WKTR/DRT, which is nice for people trying to bisect things based on build archives.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2025-08-27 18:46:12 PDT
<
rdar://problem/159323672
>
Sam Sneddon [:gsnedders]
Comment 2
2025-08-27 18:49:08 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/49978
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug