RESOLVED CONFIGURATION CHANGED Bug 274330
editing/execCommand layout tests intermittently failing on mac-wk1 (off-by-one baseline issue) 
https://bugs.webkit.org/show_bug.cgi?id=274330
Summary editing/execCommand layout tests intermittently failing on mac-wk1 (off-by-on...
Ryan Haddad
Reported 2024-05-17 13:12:50 PDT
Layout tests in the editing/execCommand are intermittently failing on mac-wk1. This appears to be due to the expected results being off by one test, causing all subsequent ones to fail. Example: https://build.webkit.org/results/Apple-Ventura-Release-AppleSilicon-WK1-Tests/278913@main%20(9468)/results.html
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-05-17 13:13:01 PDT
<rdar://problem/128290437>
Jonathan Bedard
Comment 2 2024-05-17 13:33:28 PDT
This is absolutely an off-by-1 issue. Unlike last time, this isn't about ref tests, it's about normal test diffs, the bug almost certainly lies in DumpRenderTree. I have a hunch it's also specific to WebKitLegacy, but we don't have concrete data about that.
Ryan Haddad
Comment 3 2024-05-17 14:18:28 PDT
It appears that this particular case was already known and the offending tests had been skipped. They were accidentally unskipped as part of 278894@main https://github.com/WebKit/WebKit/commit/f606fe226b6f65e34820bdb8b17cc2fab81a14ec#diff-a0da6d7c099dd9e2d22a140bbdf209f01f0f0394d19609d6d3e7c60a85ad760dL2330-L2332
Darin Adler
Comment 4 2024-05-17 14:28:33 PDT
Can we immediately revert those incorrect changes?
Ryan Haddad
Comment 5 2024-05-17 15:53:21 PDT
The incorrect changes were un-done in https://commits.webkit.org/278925@main
Note You need to log in before you can comment on or make changes to this bug.