Bug 29617 - WebKit Chromium Port: Upstreaming gyp files into webkit
: WebKit Chromium Port: Upstreaming gyp files into webkit
Status: RESOLVED FIXED
: WebKit
WebKit Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 28396
  Show dependency treegraph
 
Reported: 2009-09-21 14:51 PST by
Modified: 2009-09-22 10:34 PST (History)


Attachments
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi (40.48 KB, patch)
2009-09-21 15:11 PST, Yaar Schnitman
levin: review-
Review Patch | Details | Formatted Diff | Diff
copyright & FIXME resolved (44.45 KB, patch)
2009-09-21 16:37 PST, Yaar Schnitman
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2009-09-21 14:51:08 PST
This patch is part of the webkit chromium port project as described here:
http://trac.webkit.org/wiki/Chromium

The webcore & javascriptcore building steps of chromium have been decoupled from chromium gyp-based build system, and can now be moved to the webkit tree:

1. A chromium port directory was created: WebKit/chromium
2. features.gypi, which controls which features are turned on/off in webkit, has been imported: WebKit/chromium/features.gypi
3. WebCore.gyp and JavaScriptCore.gyp have been ported and live inside the new directories WebCore/WebCore.gyp/ and JavaScriptCore/JavaScriptCore.gyp/. (We use dedicated directories so that the gyp outputs don't overwrite the existing generic xcodeproj, vsproj, files.

Once this patch is commited, downstream chromium gyp files should be updated to point at new upstream gyps.
------- Comment #1 From 2009-09-21 15:11:42 PST -------
Created an attachment (id=39885) [details]
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi
------- Comment #2 From 2009-09-21 15:19:09 PST -------
(From update of attachment 39885 [details])
Quick comments from a brief look:

The copyrights are not a correct format for WebKit.

"TODO(*):" should be "FIXME:"
------- Comment #3 From 2009-09-21 16:37:00 PST -------
Created an attachment (id=39893) [details]
copyright & FIXME resolved

Thanks for reviewing this.
------- Comment #4 From 2009-09-22 10:34:51 PST -------
(From update of attachment 39893 [details])
Clearing flags on attachment: 39893

Committed r48640: <http://trac.webkit.org/changeset/48640>
------- Comment #5 From 2009-09-22 10:34:54 PST -------
All reviewed patches have been landed.  Closing bug.