Bug 29617 - WebKit Chromium Port: Upstreaming gyp files into webkit
: WebKit Chromium Port: Upstreaming gyp files into webkit
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Misc.
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Yaar Schnitman
:
Depends on:
Blocks: 28396
  Show dependency treegraph
 
Reported: 2009-09-21 14:51 PDT by Yaar Schnitman
Modified: 2009-09-22 10:34 PDT (History)
2 users (show)

See Also:


Attachments
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi (40.48 KB, patch)
2009-09-21 15:11 PDT, Yaar Schnitman
levin: review-
Details | Formatted Diff | Diff
copyright & FIXME resolved (44.45 KB, patch)
2009-09-21 16:37 PDT, Yaar Schnitman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yaar Schnitman 2009-09-21 14:51:08 PDT
This patch is part of the webkit chromium port project as described here:
http://trac.webkit.org/wiki/Chromium

The webcore & javascriptcore building steps of chromium have been decoupled from chromium gyp-based build system, and can now be moved to the webkit tree:

1. A chromium port directory was created: WebKit/chromium
2. features.gypi, which controls which features are turned on/off in webkit, has been imported: WebKit/chromium/features.gypi
3. WebCore.gyp and JavaScriptCore.gyp have been ported and live inside the new directories WebCore/WebCore.gyp/ and JavaScriptCore/JavaScriptCore.gyp/. (We use dedicated directories so that the gyp outputs don't overwrite the existing generic xcodeproj, vsproj, files.

Once this patch is commited, downstream chromium gyp files should be updated to point at new upstream gyps.
Comment 1 Yaar Schnitman 2009-09-21 15:11:42 PDT
Created attachment 39885 [details]
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi
Comment 2 David Levin 2009-09-21 15:19:09 PDT
Comment on attachment 39885 [details]
Adds JavaScriptCore.gyp, WebCore.gyp and chromium/features.gypi

Quick comments from a brief look:

The copyrights are not a correct format for WebKit.

"TODO(*):" should be "FIXME:"
Comment 3 Yaar Schnitman 2009-09-21 16:37:00 PDT
Created attachment 39893 [details]
copyright & FIXME resolved

Thanks for reviewing this.
Comment 4 WebKit Commit Bot 2009-09-22 10:34:51 PDT
Comment on attachment 39893 [details]
copyright & FIXME resolved

Clearing flags on attachment: 39893

Committed r48640: <http://trac.webkit.org/changeset/48640>
Comment 5 WebKit Commit Bot 2009-09-22 10:34:54 PDT
All reviewed patches have been landed.  Closing bug.