Bug 294587 – [ASSERTION FAILED: Custom property should be handled by applyCustomProperty] variable-css-wide-keywords.html crashes on Debug build

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: CSS

[Ahmad Saleem]

Hi Team,

While importing css-variables from WPT, it seems we crash following WPT test case:

WPT Test Case Live Link: http://wpt.live/css/css-variables/variable-css-wide-keywords.html

EWS Link for crash logs: https://ews-build.s3-us-west-2.amazonaws.com/macOS-Sequoia-Debug-WK2-Tests-EWS/b6247bde-25889-stress-mode/results.html

Crash log:

No crash log found for com.apple.WebKit.WebContent.Development:12303.

stdout:

stderr:
ASSERTION FAILED: Custom property should be handled by applyCustomProperty
id != CSSPropertyCustom
/Volumes/Data/worker/macOS-Sequoia-Debug-Build-EWS/build/Source/WebCore/style/StyleBuilder.cpp(308) : void WebCore::Style::Builder::applyProperty(CSSPropertyID, CSSValue &, SelectorChecker::LinkMatchMask, CascadeLevel)
1   0x3071730c8 WebCore::Style::Builder::applyProperty(WebCore::CSSPropertyID, WebCore::CSSValue&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)
2   0x307172fe0 WebCore::Style::Builder::applyRollbackCascadeProperty(WebCore::Style::PropertyCascade::Property const&, WebCore::SelectorChecker::LinkMatchMask)
3   0x3071b7328 WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0::operator()(WebCore::CSSWideKeyword&&) const
4   0x3071b6f0c decltype(auto) WTF::visitOneVariant<0ul, WTF::Visitor<WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_1>, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>>(WTF::Visitor<WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_1>&&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&)
5   0x3071742e8 decltype(visitOneVariant(makeVisitor(std::forward<WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0>(fp0), std::forward<WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_1>(fp0)), asVariant(std::forward<std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>>(fp)))) WTF::switchOn<std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_1>(std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_0&&, WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)::$_1&&)
6   0x307172e2c WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&, std::__1::variant<WTF::Ref<WebCore::Style::CustomProperty const, WTF::RawPtrTraits<WebCore::Style::CustomProperty const>, WTF::DefaultRefDerefTraits<WebCore::Style::CustomProperty const>>, WebCore::CSSWideKeyword>&&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)
7   0x307172440 WebCore::Style::Builder::applyCustomPropertyImpl(WTF::AtomString const&, WebCore::Style::PropertyCascade::Property const&)
8   0x3071725f0 WebCore::Style::Builder::applyCustomProperty(WTF::AtomString const&)
9   0x3044cf3ec WebCore::propertyValueForVariableName(WTF::AtomString const&, WebCore::CSSValueID, WebCore::Style::BuilderState&)
10  0x3044cf668 WebCore::CSSVariableReferenceValue::tryResolveSimpleReference(WebCore::Style::BuilderState&) const
11  0x30445c40c bool WebCore::CSSVariableReferenceValue::resolveAndCacheValue<WebCore::CSSPendingSubstitutionValue::resolveValue(WebCore::Style::BuilderState&, WebCore::CSSPropertyID) const::$_0>(WebCore::Style::BuilderState&, WebCore::CSSPendingSubstitutionValue::resolveValue(WebCore::Style::BuilderState&, WebCore::CSSPropertyID) const::$_0 const&) const
12  0x30445c320 WebCore::CSSPendingSubstitutionValue::resolveValue(WebCore::Style::BuilderState&, WebCore::CSSPropertyID) const
13  0x307174358 WebCore::Style::Builder::resolveVariableReferences(WebCore::CSSPropertyID, WebCore::CSSValue&)::$_0::operator()() const
14  0x307173738 WebCore::Style::Builder::resolveVariableReferences(WebCore::CSSPropertyID, WebCore::CSSValue&)
15  0x3071730e8 WebCore::Style::Builder::applyProperty(WebCore::CSSPropertyID, WebCore::CSSValue&, WebCore::SelectorChecker::LinkMatchMask, WebCore::Style::CascadeLevel)
16  0x307191fd4 WebCore::Style::Builder::applyCascadeProperty(WebCore::Style::PropertyCascade::Property const&)::'lambda'(WebCore::SelectorChecker::LinkMatchMask)::operator()(WebCore::SelectorChecker::LinkMatchMask) const
17  0x307171eb8 WebCore::Style::Builder::applyCascadeProperty(WebCore::Style::PropertyCascade::Property const&)
18  0x3071b62ec void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long)::operator()(unsigned long) const
19  0x3071b64d0 void WTF::forEachSetBit<unsigned long long, void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long)>(std::__1::span<unsigned long long const, 18446744073709551615ul>, unsigned long, void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long) const&)::'lambda'(unsigned long long, unsigned long)::operator()(unsigned long long, unsigned long) const
20  0x3071b63cc void WTF::forEachSetBit<unsigned long long, void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long)>(std::__1::span<unsigned long long const, 18446744073709551615ul>, unsigned long, void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long) const&)
21  0x3071b6218 void WTF::BitSet<382ul, unsigned long long>::forEachSetBit<void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long)>(unsigned long, void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)::'lambda'(unsigned long) const&) const
22  0x307172080 void WebCore::Style::Builder::applyPropertiesImpl<(WebCore::Style::Builder::CustomPropertyCycleTracking)0>(int, int)
23  0x307171b04 WebCore::Style::Builder::applyProperties(int, int)
24  0x3071719c4 WebCore::Style::Builder::applyNonHighPriorityProperties()
25  0x3071e31d4 WebCore::Style::Resolver::applyMatchedProperties(WebCore::Style::Resolver::State&, WebCore::Style::MatchResult const&, WebCore::Style::PropertyCascade::IncludedProperties&&)
26  0x3071e2c54 WebCore::Style::Resolver::unadjustedStyleForElement(WebCore::Element&, WebCore::Style::ResolutionContext const&, WebCore::RuleMatchingBehavior)
27  0x3071f2974 WebCore::Style::TreeResolver::styleForStyleable(WebCore::Styleable const&, WebCore::Style::TreeResolver::ResolutionType, WebCore::Style::ResolutionContext const&, WebCore::RenderStyle const*)::$_0::operator()() const
28  0x3071f20e8 WebCore::Style::TreeResolver::styleForStyleable(WebCore::Styleable const&, WebCore::Style::TreeResolver::ResolutionType, WebCore::Style::ResolutionContext const&, WebCore::RenderStyle const*)
29  0x3071f2f20 WebCore::Style::TreeResolver::resolveElement(WebCore::Element&, WebCore::RenderStyle const*, WebCore::Style::TreeResolver::ResolutionType)
30  0x3071f8428 WebCore::Style::TreeResolver::resolveComposedTree()
31  0x3071f9ab4 WebCore::Style::TreeResolver::resolve()
com.apple.WebKit.WebContent.Development terminated (pid 12303) for reason: crash
LEAK: 1 WebPageProxy

Just raising so we can fix it.

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/154140335>

[Antti Koivisto]

*** This bug has been marked as a duplicate of bug 294585 ***