RESOLVED LATER 29343
Update WebGL-related copyrights
https://bugs.webkit.org/show_bug.cgi?id=29343
Summary Update WebGL-related copyrights
Kenneth Russell
Reported 2009-09-17 13:12:53 PDT
Google contributed a significant amount of the code integrated by Apple in https://bugs.webkit.org/show_bug.cgi?id=29010 , but I neglected to update the copyright headers in the affected files. On the recommendation of Apple here is a minor patch updating the relevant files' copyrights.
Attachments
Patch updating copyrights to affected files. (17.05 KB, patch)
2009-09-17 16:48 PDT, Kenneth Russell
eric: review-
Oliver Hunt
Comment 1 2009-09-17 16:04:27 PDT
(In reply to comment #0) > Google contributed a significant amount of the code integrated by Apple in > https://bugs.webkit.org/show_bug.cgi?id=29010 , but I neglected to update the > copyright headers in the affected files. On the recommendation of Apple here is > a minor patch updating the relevant files' copyrights. Please list the "significant" code -- my understanding is that it was just the original implementations of Canvas*Array.
Kenneth Russell
Comment 2 2009-09-17 16:29:51 PDT
The contributions were: - The original implementations of the Canvas*Array classes and their IDL - Updates to many of the CanvasRenderingContext3D entry points to bring them up to date with the then-current WebGL specification - Additions of the CanvasArray constructors to the DOMWindow IDL These are the only files touched by the attached copyright notice patch.
Oliver Hunt
Comment 3 2009-09-17 16:32:49 PDT
(In reply to comment #2) > The contributions were: > - The original implementations of the Canvas*Array classes and their IDL > - Updates to many of the CanvasRenderingContext3D entry points to bring them > up to date with the then-current WebGL specification > - Additions of the CanvasArray constructors to the DOMWindow IDL > > These are the only files touched by the attached copyright notice patch. I think the confusion here is that there is no patch attached :D
Kenneth Russell
Comment 4 2009-09-17 16:48:23 PDT
Created attachment 39736 [details] Patch updating copyrights to affected files. Sorry about that; attached.
Oliver Hunt
Comment 5 2009-10-01 20:10:07 PDT
Comment on attachment 39736 [details] Patch updating copyrights to affected files. I don't know what source files were modified, vs. started from fresh -- no point in me being the requested reviewer.
Eric Seidel (no email)
Comment 6 2009-10-02 12:28:33 PDT
Comment on attachment 39736 [details] Patch updating copyrights to affected files. No ChangeLog. r- Why are we bothering to update this? Lets just fix the copyrights next time we touch those files... no?
Oliver Hunt
Comment 7 2009-10-02 12:49:57 PDT
Closing per eric's comments -- he's right, we normally just correct copyright notices when we modify files and realise that the copyright info is out of date.
Note You need to log in before you can comment on or make changes to this bug.