Bug 29343 - Update WebGL-related copyrights
Summary: Update WebGL-related copyrights
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-17 13:12 PDT by Kenneth Russell
Modified: 2009-11-06 17:00 PST (History)
5 users (show)

See Also:


Attachments
Patch updating copyrights to affected files. (17.05 KB, patch)
2009-09-17 16:48 PDT, Kenneth Russell
eric: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2009-09-17 13:12:53 PDT
Google contributed a significant amount of the code integrated by Apple in https://bugs.webkit.org/show_bug.cgi?id=29010 , but I neglected to update the copyright headers in the affected files. On the recommendation of Apple here is a minor patch updating the relevant files' copyrights.
Comment 1 Oliver Hunt 2009-09-17 16:04:27 PDT
(In reply to comment #0)
> Google contributed a significant amount of the code integrated by Apple in
> https://bugs.webkit.org/show_bug.cgi?id=29010 , but I neglected to update the
> copyright headers in the affected files. On the recommendation of Apple here is
> a minor patch updating the relevant files' copyrights.

Please list the "significant" code -- my understanding is that it was just the original implementations of Canvas*Array.
Comment 2 Kenneth Russell 2009-09-17 16:29:51 PDT
The contributions were:
  - The original implementations of the Canvas*Array classes and their IDL
  - Updates to many of the CanvasRenderingContext3D entry points to bring them up to date with the then-current WebGL specification
  - Additions of the CanvasArray constructors to the DOMWindow IDL

These are the only files touched by the attached copyright notice patch.
Comment 3 Oliver Hunt 2009-09-17 16:32:49 PDT
(In reply to comment #2)
> The contributions were:
>   - The original implementations of the Canvas*Array classes and their IDL
>   - Updates to many of the CanvasRenderingContext3D entry points to bring them
> up to date with the then-current WebGL specification
>   - Additions of the CanvasArray constructors to the DOMWindow IDL
> 
> These are the only files touched by the attached copyright notice patch.

I think the confusion here is that there is no patch attached :D
Comment 4 Kenneth Russell 2009-09-17 16:48:23 PDT
Created attachment 39736 [details]
Patch updating copyrights to affected files. 

Sorry about that; attached.
Comment 5 Oliver Hunt 2009-10-01 20:10:07 PDT
Comment on attachment 39736 [details]
Patch updating copyrights to affected files. 

I don't know what source files were modified, vs. started from fresh -- no point in me being the requested reviewer.
Comment 6 Eric Seidel (no email) 2009-10-02 12:28:33 PDT
Comment on attachment 39736 [details]
Patch updating copyrights to affected files. 

No ChangeLog. r-
Why are we bothering to update this?  Lets just fix the copyrights next time we touch those files... no?
Comment 7 Oliver Hunt 2009-10-02 12:49:57 PDT
Closing per eric's comments -- he's right, we normally just correct copyright notices when we modify files and realise that the copyright info is out of date.