Canvas 3D spec has been updated and the WebKit implementation needs to match
Created attachment 39147 [details] Patch
Notes on this patch: The original work is from Ken Russell at Google. I added constructors and getters/setters for all the CanvasXXXArray types, which are specific to the WebKit JS implementation. And I added the changes to GraphicsContext3D that are specific to the Mac implementation. But all the API changes are the same as in his original patch.
Comment on attachment 39147 [details] Patch These headers have incorrect indentation -- content inside the namespace block of a header should be indented > Index: WebCore/bindings/js/JSCanvasArrayBufferConstructor.h > Index: WebCore/bindings/js/JSCanvasByteArrayConstructor.h > Index: WebCore/bindings/js/JSCanvasFloatArrayConstructor.h > Index: WebCore/bindings/js/JSCanvasIntArrayConstructor.h > Index: WebCore/bindings/js/JSCanvasShortArrayConstructor.h > Index: WebCore/bindings/js/JSCanvasUnsignedIntArrayConstructor.h > Index: WebCore/bindings/js/JSCanvasUnsignedShortArrayConstructor.h Your changes to WebCore/html/canvas/CanvasByteArray.cpp have resulted in incorrect indenting (in the implementation file we don't indent inside the namespace) Other than those minor style quirks, r=me
Sending WebCore/ChangeLog Sending WebCore/DerivedSources.make Sending WebCore/WebCore.xcodeproj/project.pbxproj Adding WebCore/bindings/js/JSCanvasArrayBufferConstructor.cpp Adding WebCore/bindings/js/JSCanvasArrayBufferConstructor.h Adding WebCore/bindings/js/JSCanvasArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasByteArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasByteArrayConstructor.h Adding WebCore/bindings/js/JSCanvasByteArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasFloatArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasFloatArrayConstructor.h Adding WebCore/bindings/js/JSCanvasFloatArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasIntArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasIntArrayConstructor.h Adding WebCore/bindings/js/JSCanvasIntArrayCustom.cpp Sending WebCore/bindings/js/JSCanvasRenderingContext3DCustom.cpp Adding WebCore/bindings/js/JSCanvasShortArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasShortArrayConstructor.h Adding WebCore/bindings/js/JSCanvasShortArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasUnsignedByteArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasUnsignedByteArrayConstructor.h Adding WebCore/bindings/js/JSCanvasUnsignedByteArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasUnsignedIntArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasUnsignedIntArrayConstructor.h Adding WebCore/bindings/js/JSCanvasUnsignedIntArrayCustom.cpp Adding WebCore/bindings/js/JSCanvasUnsignedShortArrayConstructor.cpp Adding WebCore/bindings/js/JSCanvasUnsignedShortArrayConstructor.h Adding WebCore/bindings/js/JSCanvasUnsignedShortArrayCustom.cpp Sending WebCore/bindings/js/JSDOMWindowCustom.cpp Sending WebCore/html/HTMLCanvasElement.cpp Adding WebCore/html/canvas/CanvasArray.cpp Adding WebCore/html/canvas/CanvasArray.h Adding WebCore/html/canvas/CanvasArray.idl Adding WebCore/html/canvas/CanvasArrayBuffer.cpp Adding WebCore/html/canvas/CanvasArrayBuffer.h Adding WebCore/html/canvas/CanvasArrayBuffer.idl Sending WebCore/html/canvas/CanvasByteArray.cpp Sending WebCore/html/canvas/CanvasByteArray.h Sending WebCore/html/canvas/CanvasByteArray.idl Adding WebCore/html/canvas/CanvasFloatArray.cpp Adding WebCore/html/canvas/CanvasFloatArray.h Adding WebCore/html/canvas/CanvasFloatArray.idl Adding WebCore/html/canvas/CanvasIntArray.cpp Adding WebCore/html/canvas/CanvasIntArray.h Adding WebCore/html/canvas/CanvasIntArray.idl Sending WebCore/html/canvas/CanvasRenderingContext3D.cpp Sending WebCore/html/canvas/CanvasRenderingContext3D.h Sending WebCore/html/canvas/CanvasRenderingContext3D.idl Adding WebCore/html/canvas/CanvasShortArray.cpp Adding WebCore/html/canvas/CanvasShortArray.h Adding WebCore/html/canvas/CanvasShortArray.idl Sending WebCore/html/canvas/CanvasTexture.cpp Sending WebCore/html/canvas/CanvasTexture.h Adding WebCore/html/canvas/CanvasUnsignedByteArray.cpp Adding WebCore/html/canvas/CanvasUnsignedByteArray.h Adding WebCore/html/canvas/CanvasUnsignedByteArray.idl Adding WebCore/html/canvas/CanvasUnsignedIntArray.cpp Adding WebCore/html/canvas/CanvasUnsignedIntArray.h Adding WebCore/html/canvas/CanvasUnsignedIntArray.idl Adding WebCore/html/canvas/CanvasUnsignedShortArray.cpp Adding WebCore/html/canvas/CanvasUnsignedShortArray.h Adding WebCore/html/canvas/CanvasUnsignedShortArray.idl Sending WebCore/page/DOMWindow.idl Sending WebCore/platform/graphics/GraphicsContext3D.h Sending WebCore/platform/graphics/mac/GraphicsContext3DMac.cpp Transmitting file data ................................................................. Committed revision 48150.